Re: Review Request 41372: Added update for systemd in centos Getting Started.

2015-12-16 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41372/#review110797
---

Ship it!


Ship It!

- Gilbert Song


On Dec. 16, 2015, 3:07 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41372/
> ---
> 
> (Updated Dec. 16, 2015, 3:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Gilbert Song, Jojy Varghese, 
> Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3954
> https://issues.apache.org/jira/browse/MESOS-3954
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Several bugs related to older versions of systemd have caused failures
> on centos 7.1 (e.g. MESOS-3296, MESOS-3352, MESOS-3352). We now add
> instructions to explicity update systemd as part of the system
> requirements.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 
> 
> Diff: https://reviews.apache.org/r/41372/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 41372: Added update for systemd in centos Getting Started.

2015-12-16 Thread Kevin Klues 


> On Dec. 17, 2015, 12:09 a.m., Jojy Varghese wrote:
> > docs/getting-started.md, line 146
> > 
> >
> > I would emphaise versions with backtics.

This doesn't appear to add any special empahsis (in the markdown that is), 
because it is embedded in a code block.  I can put ticks around it, but I'd 
rather use a standard apostrophe like what is used elsewhere in the comments.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41372/#review110805
---


On Dec. 16, 2015, 11:07 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41372/
> ---
> 
> (Updated Dec. 16, 2015, 11:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Gilbert Song, Jojy Varghese, 
> Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3954
> https://issues.apache.org/jira/browse/MESOS-3954
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Several bugs related to older versions of systemd have caused failures
> on centos 7.1 (e.g. MESOS-3296, MESOS-3352, MESOS-3352). We now add
> instructions to explicity update systemd as part of the system
> requirements.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 
> 
> Diff: https://reviews.apache.org/r/41372/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 41372: Added update for systemd in centos Getting Started.

2015-12-16 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41372/#review110853
---

Ship it!



docs/getting-started.md (line 146)


We generally seem to use ticks for (versioned) product/project names within 
code-blocks of this document.
```
'devtoolset-2'
'subversion > 1.8'
'Mesos > 0.21.0'
```

But also backticks sometimes;
```
`nss`
```

Overall, I think it really does not make much sense to use backticks in 
these spots.

For now, I think ticks are more consistent, so let's do:
```
[..] in 'systemd version 218', which [..]
```


- Till Toenshoff


On Dec. 16, 2015, 11:07 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41372/
> ---
> 
> (Updated Dec. 16, 2015, 11:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Gilbert Song, Jojy Varghese, 
> Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3954
> https://issues.apache.org/jira/browse/MESOS-3954
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Several bugs related to older versions of systemd have caused failures
> on centos 7.1 (e.g. MESOS-3296, MESOS-3352, MESOS-3352). We now add
> instructions to explicity update systemd as part of the system
> requirements.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 
> 
> Diff: https://reviews.apache.org/r/41372/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 41372: Added update for systemd in centos Getting Started.

2015-12-16 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41372/
---

(Updated Dec. 17, 2015, 2:30 a.m.)


Review request for mesos, Benjamin Hindman, Gilbert Song, Jojy Varghese, Joris 
Van Remoortere, and Neil Conway.


Bugs: MESOS-3954
https://issues.apache.org/jira/browse/MESOS-3954


Repository: mesos


Description (updated)
---

Several bugs related to older versions of systemd have caused failures
on centos 7.1 (e.g. MESOS-3296, MESOS-3352, MESOS-3352). We now add
instructions to explicity update systemd as part of the system
requirements.

Review: https://reviews.apache.org/r/41372


Diffs (updated)
-

  docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 

Diff: https://reviews.apache.org/r/41372/diff/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 41372: Added update for systemd in centos Getting Started.

2015-12-16 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41372/#review110805
---



docs/getting-started.md (line 146)


I would emphaise versions with backtics.


- Jojy Varghese


On Dec. 16, 2015, 11:07 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41372/
> ---
> 
> (Updated Dec. 16, 2015, 11:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Gilbert Song, Jojy Varghese, 
> Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-3954
> https://issues.apache.org/jira/browse/MESOS-3954
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Several bugs related to older versions of systemd have caused failures
> on centos 7.1 (e.g. MESOS-3296, MESOS-3352, MESOS-3352). We now add
> instructions to explicity update systemd as part of the system
> requirements.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 
> 
> Diff: https://reviews.apache.org/r/41372/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 41372: Added update for systemd in centos Getting Started.

2015-12-15 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41372/#review110545
---


Hey Kevin,
This is a great addition.
Can you be more specific around the systemd requirements in the documentation?
Here is a reference as some help:
https://github.com/apache/mesos/blob/293639961525e49e17dccd8d380684b8d668840d/src/linux/systemd.cpp#L128-L139

- Joris Van Remoortere


On Dec. 15, 2015, 7:14 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41372/
> ---
> 
> (Updated Dec. 15, 2015, 7:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-3954
> https://issues.apache.org/jira/browse/MESOS-3954
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Several bugs related to older versions of systemd have caused failures
> on centos 7.1 (e.g. MESOS-3296, MESOS-3352, MESOS-3352). We now add
> instructions to explicity update systemd as part of the system
> requirements.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 
> 
> Diff: https://reviews.apache.org/r/41372/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 41372: Added update for systemd in centos Getting Started.

2015-12-15 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41372/
---

(Updated Dec. 15, 2015, 9:26 p.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Neil 
Conway.


Bugs: MESOS-3954
https://issues.apache.org/jira/browse/MESOS-3954


Repository: mesos


Description
---

Several bugs related to older versions of systemd have caused failures
on centos 7.1 (e.g. MESOS-3296, MESOS-3352, MESOS-3352). We now add
instructions to explicity update systemd as part of the system
requirements.


Diffs (updated)
-

  docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 

Diff: https://reviews.apache.org/r/41372/diff/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 41372: Added update for systemd in centos Getting Started.

2015-12-14 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41372/
---

(Updated Dec. 15, 2015, 1:05 a.m.)


Review request for mesos, Benjamin Hindman and Neil Conway.


Summary (updated)
-

Added update for systemd in centos Getting Started.


Bugs: MESOS-3954
https://issues.apache.org/jira/browse/MESOS-3954


Repository: mesos


Description
---

Several bugs related to older versions of systemd have caused failures
on centos 7.1 (e.g. MESOS-3296, MESOS-3352, MESOS-3352). We now add
instructions to explicity update systemd as part of the system
requirements.


Diffs
-

  docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb 

Diff: https://reviews.apache.org/r/41372/diff/


Testing
---


Thanks,

Kevin Klues