Re: Review Request 41408: Updated documentation for implicit roles.

2015-12-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41408/ --- (Updated Dec. 18, 2015, 8 p.m.) Review request for mesos, Adam B and Yongqiao

Re: Review Request 41408: Updated documentation for implicit roles.

2015-12-18 Thread Neil Conway
> On Dec. 18, 2015, 6:25 a.m., Adam B wrote: > > src/master/flags.cpp, lines 187-189 > > > > > > Don't forget to update configuration.md to match your change to the > > flags. This was already done as far as I can

Re: Review Request 41408: Updated documentation for implicit roles.

2015-12-18 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41408/#review111312 --- Ship it! Ship It! - Adam B On Dec. 18, 2015, noon, Neil Conway

Re: Review Request 41408: Updated documentation for implicit roles.

2015-12-18 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41408/#review111356 --- docs/roles.md (line 29)

Re: Review Request 41408: Updated documentation for implicit roles.

2015-12-18 Thread Guangya Liu
> On 十二月 19, 2015, 3:58 a.m., Guangya Liu wrote: > > docs/roles.md, line 29 > > > > > > One minor comment: The whitelist is already a keyword when mesos master > > star up, not sure if this may bring some confusion

Re: Review Request 41408: Updated documentation for implicit roles.

2015-12-17 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41408/#review22 --- Looks good, but please also update the CHANGELOG and

Re: Review Request 41408: Updated documentation for implicit roles.

2015-12-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41408/#review110575 --- Patch looks great! Reviews applied: [40995, 41075, 41225, 41408]