Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/#review111221 --- Ship it! src/tests/containerizer/docker_containerizer_tests.cpp

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 18, 2015, 3:12 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/#review111317 --- Ship it! LGTM - Anand Mazumdar On Dec. 18, 2015, 11:58 p.m.,

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/#review111306 --- src/common/http.cpp (lines 232 - 259)

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/#review111307 --- Ship it! LGTM , minus a query about using `model(...)` and not

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 18, 2015, 3:58 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

> On Dec. 18, 2015, 11:21 p.m., Anand Mazumdar wrote: > > src/common/http.cpp, line 299 > > > > > > Shouldn't this be: > > > > ``` > > object.values["container"] = std::move(task.container()); > >

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

> On Dec. 18, 2015, 10:35 a.m., Jie Yu wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, lines 506-510 > > > > > > Maybe remove this in a followup patch? Thanks for spotting it, Jie!

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 18, 2015, 2:45 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 17, 2015, 11:57 a.m.) Review request for mesos, Artem

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 17, 2015, 11:58 a.m.) Review request for mesos, Artem

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 16, 2015, 6:03 p.m.) Review request for mesos and Artem