Re: Review Request 41472: Disallowed dynamic reservations for roles not on the role whitelist.

2016-01-03 Thread Adam B
> On Dec. 21, 2015, 7:46 a.m., Michael Park wrote: > > src/master/http.cpp, line 1001 > > > > > > We actually don't need this `if` statement. Although the `role` field > > is marked `optional`, we "fill it in"

Re: Review Request 41472: Disallowed dynamic reservations for roles not on the role whitelist.

2015-12-21 Thread Michael Park
> On Dec. 17, 2015, 1:17 a.m., Michael Park wrote: > > src/master/http.cpp, lines 1000-1006 > > > > > > Hm, should this be added to `validation::operation::validate` instead? > > That way if/when we have

Re: Review Request 41472: Disallowed dynamic reservations for roles not on the role whitelist.

2015-12-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41472/#review111483 --- src/master/http.cpp (line 1001)

Re: Review Request 41472: Disallowed dynamic reservations for roles not on the role whitelist.

2015-12-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41472/#review48 --- Patch looks great! Reviews applied: [40995, 41075, 41225, 41408,

Re: Review Request 41472: Disallowed dynamic reservations for roles not on the role whitelist.

2015-12-18 Thread Michael Park
> On Dec. 17, 2015, 1:17 a.m., Michael Park wrote: > > src/master/http.cpp, lines 1000-1006 > > > > > > Hm, should this be added to `validation::operation::validate` instead? > > That way if/when we have

Re: Review Request 41472: Disallowed dynamic reservations for roles not on the role whitelist.

2015-12-18 Thread Neil Conway
> On Dec. 17, 2015, 1:17 a.m., Michael Park wrote: > > src/master/http.cpp, lines 1000-1006 > > > > > > Hm, should this be added to `validation::operation::validate` instead? > > That way if/when we have

Re: Review Request 41472: Disallowed dynamic reservations for roles not on the role whitelist.

2015-12-17 Thread Adam B
> On Dec. 16, 2015, 5:17 p.m., Michael Park wrote: > > src/master/http.cpp, lines 1000-1006 > > > > > > Hm, should this be added to `validation::operation::validate` instead? > > That way if/when we have

Re: Review Request 41472: Disallowed dynamic reservations for roles not on the role whitelist.

2015-12-17 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41472/#review41 --- Ship it! Looks good to me. Address MPark's concern and let's

Re: Review Request 41472: Disallowed dynamic reservations for roles not on the role whitelist.

2015-12-16 Thread Neil Conway
> On Dec. 17, 2015, 1:17 a.m., Michael Park wrote: > > src/master/http.cpp, lines 1000-1006 > > > > > > Hm, should this be added to `validation::operation::validate` instead? > > That way if/when we have

Re: Review Request 41472: Disallowed dynamic reservations for roles not on the role whitelist.

2015-12-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41472/#review110830 --- src/master/http.cpp (lines 1000 - 1006)