Re: Review Request 41510: Cleaned up STL I/O includes in external containerizer.

2016-01-04 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41510/#review112530
---

Ship it!


Ship It!

- Michael Park


On Dec. 22, 2015, 5:51 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41510/
> ---
> 
> (Updated Dec. 22, 2015, 5:51 p.m.)
> 
> 
> Review request for mesos, Michael Park and Till Toenshoff.
> 
> 
> Bugs: MESOS-4183
> https://issues.apache.org/jira/browse/MESOS-4183
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove unused I/O includes, clean up blank lines and include order.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/external_containerizer.hpp 
> a5b4079a8f89c0c144468b42787c6cec78692d63 
>   src/slave/containerizer/external_containerizer.cpp 
> 04cf31e005c2be8af0f80dbf856bb94b2ab5351a 
> 
> Diff: https://reviews.apache.org/r/41510/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 41510: Cleaned up STL I/O includes in external containerizer.

2015-12-22 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41510/
---

(Updated Dec. 22, 2015, 5:51 p.m.)


Review request for mesos, Michael Park and Till Toenshoff.


Changes
---

Addressed comments; additional cleanup.


Bugs: MESOS-4183
https://issues.apache.org/jira/browse/MESOS-4183


Repository: mesos


Description
---

Remove unused I/O includes, clean up blank lines and include order.


Diffs (updated)
-

  src/slave/containerizer/external_containerizer.hpp 
a5b4079a8f89c0c144468b42787c6cec78692d63 
  src/slave/containerizer/external_containerizer.cpp 
04cf31e005c2be8af0f80dbf856bb94b2ab5351a 

Diff: https://reviews.apache.org/r/41510/diff/


Testing
---

make check on Mac OS 10.10.4.


Thanks,

Alexander Rukletsov

Re: Review Request 41510: Cleaned up STL I/O includes in external containerizer.

2015-12-18 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41510/#review80
---

Ship it!



src/slave/containerizer/external_containerizer.cpp (line 22)


Only focussing on I/O related headers, `iomanip` is unused here as well and 
should be removed.


- Benjamin Bannier


On Dec. 17, 2015, 2:37 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41510/
> ---
> 
> (Updated Dec. 17, 2015, 2:37 p.m.)
> 
> 
> Review request for mesos, Michael Park and Till Toenshoff.
> 
> 
> Bugs: MESOS-4183
> https://issues.apache.org/jira/browse/MESOS-4183
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove unused I/O includes, clean up blank lines and include order.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/external_containerizer.hpp 
> a5b4079a8f89c0c144468b42787c6cec78692d63 
>   src/slave/containerizer/external_containerizer.cpp 
> 04cf31e005c2be8af0f80dbf856bb94b2ab5351a 
> 
> Diff: https://reviews.apache.org/r/41510/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 41510: Cleaned up STL I/O includes in external containerizer.

2015-12-17 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41510/#review110977
---

Ship it!


Ship It!

- Gilbert Song


On Dec. 17, 2015, 6:37 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41510/
> ---
> 
> (Updated Dec. 17, 2015, 6:37 a.m.)
> 
> 
> Review request for mesos, Michael Park and Till Toenshoff.
> 
> 
> Bugs: MESOS-4183
> https://issues.apache.org/jira/browse/MESOS-4183
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove unused I/O includes, clean up blank lines and include order.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/external_containerizer.hpp 
> a5b4079a8f89c0c144468b42787c6cec78692d63 
>   src/slave/containerizer/external_containerizer.cpp 
> 04cf31e005c2be8af0f80dbf856bb94b2ab5351a 
> 
> Diff: https://reviews.apache.org/r/41510/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>