Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

2015-12-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41603/#review111644 --- Patch looks great! Reviews applied: [41514, 41515, 41603] Passed

Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

2015-12-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41603/#review111641 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 22, 2015, 6:08

Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

2015-12-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41603/ --- (Updated Dec. 22, 2015, 6:08 p.m.) Review request for mesos, Bernd Mathiske, Jo

Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

2015-12-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41603/#review111608 --- Patch looks great! Reviews applied: [41514, 41515, 41603] Passed

Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

2015-12-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41603/ --- (Updated Dec. 22, 2015, 11:16 a.m.) Review request for mesos, Bernd Mathiske, J

Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

2015-12-22 Thread Alexander Rukletsov
> On Dec. 21, 2015, 11:38 p.m., Guangya Liu wrote: > > src/master/quota_handler.cpp, lines 57-60 > > > > > > Not yours but it would be greate to update it as following: > > > > using mesos::quota::QuotaInfo;

Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

2015-12-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41603/ --- (Updated Dec. 22, 2015, 11:01 a.m.) Review request for mesos, Bernd Mathiske, J

Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

2015-12-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41603/#review111555 --- src/master/quota_handler.cpp (lines 57 - 60)

Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

2015-12-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41603/#review111531 --- Patch looks great! Reviews applied: [41514, 41515, 41603] Passed

Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

2015-12-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41603/ --- (Updated Dec. 21, 2015, 2:17 p.m.) Review request for mesos, Bernd Mathiske, Jo

Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

2015-12-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41603/#review111462 --- src/master/quota_handler.cpp (line 60)

Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

2015-12-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41603/#review111461 --- Ship it! Ship It! - Joerg Schad On Dec. 21, 2015, 1:30 p.m., Al