Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/ --- (Updated Jan. 12, 2016, 9:56 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/#review113962 --- I thought we said we'd leave info.set_checkpoint(true); in the

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/#review113994 --- Bad patch! Reviews applied: [41649] Failed command:

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/ --- (Updated Jan. 12, 2016, 3:01 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/#review114097 --- Ship it! Looks great! Only a handful of minor doc/comment

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

> On Jan. 9, 2016, 12:06 a.m., Adam B wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 284 > > > > > > The hierarchicalDRF allocator shouldn't care about the framework's > > checkpointing state anymore,

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

> On Jan. 8, 2016, 10:12 p.m., Adam B wrote: > > src/internal/devolve.cpp, line 70 > > > > > > BUG? Wouldn't you still need to `set_checkpoint(true)`, since the > > SlaveInfo.checkpoint protobuf defaults to false,

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/ --- (Updated Jan. 11, 2016, 10:07 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/#review113779 --- Patch looks great! Reviews applied: [41649] Passed command:

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/#review113556 --- Ship it! Besides these two minor suggestions, I think this is

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

> On Jan. 6, 2016, 2:22 a.m., Joerg Schad wrote: > > include/mesos/mesos.proto, line 482 > > > > > > Let us doublecheck we actually need a deprecation cycle here: The > > critical scenario would be in my opinion if

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/#review113457 --- Ship it! lgtm! src/master/master.cpp (line 1076)

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/ --- (Updated Jan. 8, 2016, 12:46 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/ --- (Updated Jan. 7, 2016, 5:13 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/#review113279 --- Patch looks great! Reviews applied: [41649] Passed command:

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/#review113070 --- Patch looks great! Reviews applied: [41649] Passed command: