Re: Review Request 41661: Added documentation for API versioning.

2015-12-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/#review112196 --- What do you think about using "APIs" instead of "API's"? I think

Re: Review Request 41661: Added documentation for API versioning.

2015-12-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/#review112266 --- Ship it! docs/versioning.md (line 13)

Re: Review Request 41661: Added documentation for API versioning.

2015-12-29 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/ --- (Updated Dec. 30, 2015, 12:47 a.m.) Review request for mesos, Neil Conway and

Re: Review Request 41661: Added documentation for API versioning.

2015-12-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/#review112274 --- Patch looks great! Reviews applied: [41661] Passed command:

Re: Review Request 41661: Added documentation for API versioning.

2015-12-29 Thread Anand Mazumdar
> On Dec. 29, 2015, 6:26 p.m., Neil Conway wrote: > > What do you think about using "APIs" instead of "API's"? I think it is > > clearer, style-wise. > > > > Should we use backticks for endpoint suffixes like `/api/vN` etc? > > > > Content-wise: if we're writing user-facing documentation, I

Re: Review Request 41661: Added documentation for API versioning.

2015-12-29 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/ --- (Updated Dec. 29, 2015, 8:47 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 41661: Added documentation for API versioning.

2015-12-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/#review112215 --- Ship it! Ship It! docs/home.md (line 58)

Re: Review Request 41661: Added documentation for API versioning.

2015-12-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/#review112230 --- Patch looks great! Reviews applied: [41661] Passed command:

Re: Review Request 41661: Added documentation for API versioning.

2015-12-29 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/ --- (Updated Dec. 29, 2015, 9:08 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 41661: Added documentation for API versioning.

2015-12-28 Thread Jojy Varghese
> On Dec. 27, 2015, 3:25 a.m., Jojy Varghese wrote: > > docs/versioning.md, line 62 > > > > > > This section could use some formatting. > > > > Also, would be useful to take the reader through a complete

Re: Review Request 41661: Added documentation for API versioning.

2015-12-27 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/ --- (Updated Dec. 27, 2015, 9:08 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 41661: Added documentation for API versioning.

2015-12-27 Thread Anand Mazumdar
> On Dec. 27, 2015, 3:25 a.m., Jojy Varghese wrote: > > docs/versioning.md, line 7 > > > > > > ephasize 0.24.0 (in quotes). Same in other places. I tried to be consistent to other docs and they did not have quotes.

Re: Review Request 41661: Added documentation for API versioning.

2015-12-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/#review111943 --- Patch looks great! Reviews applied: [41661] Passed command:

Re: Review Request 41661: Added documentation for API versioning.

2015-12-26 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/#review111919 --- docs/versioning.md (line 7)

Re: Review Request 41661: Added documentation for API versioning.

2015-12-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/ --- (Updated Dec. 22, 2015, 10:57 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 41661: Added documentation for API versioning.

2015-12-22 Thread Anand Mazumdar
> On Dec. 22, 2015, 11:55 p.m., Guangya Liu wrote: > > docs/versioning.md, line 36 > > > > > > Not clear for what does " It would be really hard to debug an error > > that happens with Scheduler v2 API, Executor v4

Re: Review Request 41661: Added documentation for API versioning.

2015-12-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/ --- (Updated Dec. 23, 2015, 2:09 a.m.) Review request for mesos, Neil Conway and

Re: Review Request 41661: Added documentation for API versioning.

2015-12-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/#review111715 --- Patch looks great! Reviews applied: [41661] Passed command:

Re: Review Request 41661: Added documentation for API versioning.

2015-12-22 Thread Anand Mazumdar
> On Dec. 22, 2015, 11:55 p.m., Guangya Liu wrote: > > docs/versioning.md, line 22 > > > > > > Not yours, but can you please add the following to "Terminology" > > section? > > > > Scheduler API > >

Re: Review Request 41661: Added documentation for API versioning.

2015-12-22 Thread Guangya Liu
> On 十二月 22, 2015, 11:55 p.m., Guangya Liu wrote: > > docs/versioning.md, line 22 > > > > > > Not yours, but can you please add the following to "Terminology" > > section? > > > > Scheduler API > >

Re: Review Request 41661: Added documentation for API versioning.

2015-12-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/#review111679 --- docs/versioning.md (line 11)

Re: Review Request 41661: Added documentation for API versioning.

2015-12-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/#review111689 --- docs/versioning.md (line 20)

Re: Review Request 41661: Added documentation for API versioning.

2015-12-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/#review111719 --- docs/versioning.md (line 30)