Re: Review Request 41680: Reduced LogLevel in order to avoid overflowing logs.

2015-12-23 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41680/#review111767
---


Patch looks great!

Reviews applied: [41680]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 23, 2015, 9:06 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41680/
> ---
> 
> (Updated Dec. 23, 2015, 9:06 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4181
> https://issues.apache.org/jira/browse/MESOS-4181
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Especially the logging of port ranges resulted in enourmous logs, reduced the 
> log level from LOG(INFO) to VLOG(1).
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 775182515dcb52bd873ecdf98c827320251a59c8 
> 
> Diff: https://reviews.apache.org/r/41680/diff/
> 
> 
> Testing
> ---
> 
> make check and checked logs
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 41680: Reduced LogLevel in order to avoid overflowing logs.

2015-12-23 Thread Cody Maloney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41680/#review111815
---

Ship it!


Ship It!

- Cody Maloney


On Dec. 23, 2015, 9:06 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41680/
> ---
> 
> (Updated Dec. 23, 2015, 9:06 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4181
> https://issues.apache.org/jira/browse/MESOS-4181
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Especially the logging of port ranges resulted in enourmous logs, reduced the 
> log level from LOG(INFO) to VLOG(1).
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 775182515dcb52bd873ecdf98c827320251a59c8 
> 
> Diff: https://reviews.apache.org/r/41680/diff/
> 
> 
> Testing
> ---
> 
> make check and checked logs
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 41680: Reduced LogLevel in order to avoid overflowing logs.

2015-12-23 Thread Bernd Mathiske

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41680/#review111757
---

Ship it!


Ship It!

- Bernd Mathiske


On Dec. 23, 2015, 1:06 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41680/
> ---
> 
> (Updated Dec. 23, 2015, 1:06 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4181
> https://issues.apache.org/jira/browse/MESOS-4181
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Especially the logging of port ranges resulted in enourmous logs, reduced the 
> log level from LOG(INFO) to VLOG(1).
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 775182515dcb52bd873ecdf98c827320251a59c8 
> 
> Diff: https://reviews.apache.org/r/41680/diff/
> 
> 
> Testing
> ---
> 
> make check and checked logs
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>