Re: Review Request 41705: WIP: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

2015-12-25 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41705/#review111902
---



src/slave/containerizer/mesos/isolators/posix/disk.cpp (line 171)


Should we simply use `!Resources::isPersistentVolume()` here?


- Qian Zhang


On Dec. 26, 2015, 10:15 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41705/
> ---
> 
> (Updated Dec. 26, 2015, 10:15 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4198
> https://issues.apache.org/jira/browse/MESOS-4198
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for enforcing quota on (persistent) volumes (MESOS-4198).
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> d971db09083faad08f3cf18c25a79245321d1d9a 
>   src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d 
> 
> Diff: https://reviews.apache.org/r/41705/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER='DiskQuotaTest*' make check -j8
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 41705: WIP: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

2015-12-25 Thread Artem Harutyunyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41705/
---

(Updated Dec. 25, 2015, 6:15 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4198
https://issues.apache.org/jira/browse/MESOS-4198


Repository: mesos


Description (updated)
---

Added support for enforcing quota on (persistent) volumes (MESOS-4198).


Diffs
-

  src/slave/containerizer/mesos/isolators/posix/disk.cpp 
d971db09083faad08f3cf18c25a79245321d1d9a 
  src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d 

Diff: https://reviews.apache.org/r/41705/diff/


Testing
---

GTEST_FILTER='DiskQuotaTest*' make check -j8


Thanks,

Artem Harutyunyan

Re: Review Request 41705: WIP: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

2015-12-24 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41705/#review111832
---


Patch looks great!

Reviews applied: [41704, 41705]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 24, 2015, 7:51 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41705/
> ---
> 
> (Updated Dec. 24, 2015, 7:51 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4198
> https://issues.apache.org/jira/browse/MESOS-4198
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> WIP: Added support for enforcing quota on (persistent) volumes (MESOS-4198).
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> d971db09083faad08f3cf18c25a79245321d1d9a 
>   src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d 
> 
> Diff: https://reviews.apache.org/r/41705/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER='DiskQuotaTest*' make check -j8
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>