Re: Review Request 41726: Implement os::memory() for FreeBSD.

2016-01-20 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41726/#review115510 --- Ship it! Ship It! - Ian Downes On Jan. 7, 2016, 4:52 p.m.,

Re: Review Request 41726: Implement os::memory() for FreeBSD.

2016-01-07 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41726/ --- (Updated Jan. 8, 2016, 12:52 a.m.) Review request for mesos and Ian Downes.

Re: Review Request 41726: Implement os::memory() for FreeBSD.

2016-01-07 Thread David Forsythe
> On Jan. 7, 2016, 8:05 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 659 > > > > > > s/int */int* / > > Project style guide: > >

Re: Review Request 41726: Implement os::memory() for FreeBSD.

2016-01-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41726/#review113412 --- Patch looks great! Reviews applied: [41596, 41726] Passed

Re: Review Request 41726: Implement os::memory() for FreeBSD.

2015-12-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41726/#review111907 --- Bad patch! Reviews applied: [41596, 41726] Failed command:

Re: Review Request 41726: Implement os::memory() for FreeBSD.

2015-12-26 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41726/ --- (Updated Dec. 26, 2015, 11:24 p.m.) Review request for mesos and Ian Downes.

Re: Review Request 41726: Implement os::memory() for FreeBSD.

2015-12-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41726/#review111910 --- Patch looks great! Reviews applied: [41596, 41726] Passed