Re: Review Request 41727: Fixed registry client to use libprocess parse url.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41727/#review112329
---

Ship it!


Great cleanup! THanks!


src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (lines 439 
- 440)


Let's try to be consistent on indentation in this file. Either always 
starts from a new line for multiline parameters, or always starts from the same 
line.


- Jie Yu


On Dec. 26, 2015, 8:27 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41727/
> ---
> 
> (Updated Dec. 26, 2015, 8:27 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed registry client to use libprocess parse url.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> 93e7b3b466283a7732290419060ebedad3445133 
> 
> Diff: https://reviews.apache.org/r/41727/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 41727: Fixed registry client to use libprocess parse url.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41727/#review111920
---

Ship it!


LGTM!

- Gilbert Song


On Dec. 26, 2015, 12:27 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41727/
> ---
> 
> (Updated Dec. 26, 2015, 12:27 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed registry client to use libprocess parse url.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> 93e7b3b466283a7732290419060ebedad3445133 
> 
> Diff: https://reviews.apache.org/r/41727/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>