Re: Review Request 41758: Unified Container: Added passing Cmd in docker runtime config.

2015-12-30 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41758/#review112371
---



src/slave/containerizer/mesos/provisioner/store.hpp (line 47)


Ditto.


- Jie Yu


On Dec. 28, 2015, 11:50 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41758/
> ---
> 
> (Updated Dec. 28, 2015, 11:50 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4227
> https://issues.apache.org/jira/browse/MESOS-4227
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Unified Container: Added passing Cmd in docker runtime config.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> e951c96a7f9c5ff72f6993981e2e3744e3b837f6 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
> 
> Diff: https://reviews.apache.org/r/41758/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Re: Review Request 41758: Unified Container: Added passing Cmd in docker runtime config.

2015-12-28 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41758/#review112106
---


Patch looks great!

Reviews applied: [41491, 41757, 41758]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 28, 2015, 11:50 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41758/
> ---
> 
> (Updated Dec. 28, 2015, 11:50 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4227
> https://issues.apache.org/jira/browse/MESOS-4227
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Unified Container: Added passing Cmd in docker runtime config.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> e951c96a7f9c5ff72f6993981e2e3744e3b837f6 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
> 
> Diff: https://reviews.apache.org/r/41758/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>