Re: Review Request 41779: Extended Subprocess::FD to optionally not duplicate the given FD.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41779/
---

(Updated Jan. 19, 2016, 7:41 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
---

Renamed FD::CLOEXEC to FD::OWNED.


Summary (updated)
-

Extended Subprocess::FD to optionally not duplicate the given FD.


Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136


Repository: mesos


Description (updated)
---

This new option is useful when a subprocess is started with a FD, and the 
parent process does not need the FD afterwards.  In this case, the FD does not 
need to be duplicated before being sent to the child process.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
8704cd0a8af92b848eb9ff7cffe8e5251c5dcfec 
  3rdparty/libprocess/src/subprocess.cpp 
863523404b9ef1d2024c108f3e9e1c77c3916049 

Diff: https://reviews.apache.org/r/41779/diff/


Testing
---

Tests are run in the next review.


Thanks,

Joseph Wu

Re: Review Request 41779: Extended Subprocess::FD to optionally not duplicate the given FD.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41779/#review114484
---



3rdparty/libprocess/include/process/subprocess.hpp (line 126)


I would suggest an enum {DUPLICATE, NO_DUPLICATE} instead of a bool. Then 
code readers do not have to look up the method definition at call sites to 
understand what "false" might mean. Nor do you have to put a comment at every 
call site explaining "false".


- Bernd Mathiske


On Jan. 13, 2016, 6:12 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41779/
> ---
> 
> (Updated Jan. 13, 2016, 6:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4136
> https://issues.apache.org/jira/browse/MESOS-4136
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If a subprocess is started with a FD, and the parent process does not need 
> the FD afterwards, the FD does not need to be duplicated.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 8704cd0a8af92b848eb9ff7cffe8e5251c5dcfec 
>   3rdparty/libprocess/src/subprocess.cpp 
> 863523404b9ef1d2024c108f3e9e1c77c3916049 
> 
> Diff: https://reviews.apache.org/r/41779/diff/
> 
> 
> Testing
> ---
> 
> Tests are run in the next review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 41779: Extended Subprocess::FD to optionally not duplicate the given FD.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41779/
---

(Updated Jan. 13, 2016, 6:12 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
---

Rebased on a patch that refactors `Subprocess::IO`.


Summary (updated)
-

Extended Subprocess::FD to optionally not duplicate the given FD.


Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136


Repository: mesos


Description
---

If a subprocess is started with a FD, and the parent process does not need the 
FD afterwards, the FD does not need to be duplicated.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
8704cd0a8af92b848eb9ff7cffe8e5251c5dcfec 
  3rdparty/libprocess/src/subprocess.cpp 
863523404b9ef1d2024c108f3e9e1c77c3916049 

Diff: https://reviews.apache.org/r/41779/diff/


Testing
---

Tests are run in the next review.


Thanks,

Joseph Wu

Re: Review Request 41779: Extended Subprocess::FD to optionally not duplicate the given FD.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41779/#review114405
---

Ship it!


Ship It!

- Benjamin Hindman


On Jan. 14, 2016, 2:12 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41779/
> ---
> 
> (Updated Jan. 14, 2016, 2:12 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4136
> https://issues.apache.org/jira/browse/MESOS-4136
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If a subprocess is started with a FD, and the parent process does not need 
> the FD afterwards, the FD does not need to be duplicated.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 8704cd0a8af92b848eb9ff7cffe8e5251c5dcfec 
>   3rdparty/libprocess/src/subprocess.cpp 
> 863523404b9ef1d2024c108f3e9e1c77c3916049 
> 
> Diff: https://reviews.apache.org/r/41779/diff/
> 
> 
> Testing
> ---
> 
> Tests are run in the next review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>