Re: Review Request 41780: Changed ContainerLogger and Fetcher to not duplicate FDs.

2016-01-19 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41780/
---

(Updated Jan. 19, 2016, 7:41 p.m.)


Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Artem 
Harutyunyan.


Changes
---

Renamed FD::CLOEXEC to FD::OWNED.


Summary (updated)
-

Changed ContainerLogger and Fetcher to not duplicate FDs.


Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136


Repository: mesos


Description (updated)
---

This change shifts the burden of FD lifecycle management away from 
ContainerLogger module writers.
This change also cleans up the Fetcher code slightly.


Diffs (updated)
-

  include/mesos/slave/container_logger.hpp 
a2362070ead0afcef1e6c2ca784083ddb01ba51a 
  src/slave/containerizer/fetcher.cpp 4ac9149980cf7f013b318218a1b29369c5dcff17 

Diff: https://reviews.apache.org/r/41780/diff/


Testing
---

make check


Thanks,

Joseph Wu



Re: Review Request 41780: Changed ContainerLogger and Fetcher to not duplicate FDs.

2016-01-14 Thread Bernd Mathiske

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41780/#review114485
---

Ship it!


My comment on https://reviews.apache.org/r/41779/
may change "false" to "NO_DUPLICATE" here.

- Bernd Mathiske


On Jan. 13, 2016, 6:12 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41780/
> ---
> 
> (Updated Jan. 13, 2016, 6:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Artem 
> Harutyunyan.
> 
> 
> Bugs: MESOS-4136
> https://issues.apache.org/jira/browse/MESOS-4136
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change shifts the burden of FD lifecycle management away from 
> ContainerLogger module writers.
> This change also cleans up the Fetcher code slightly.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/container_logger.hpp 
> a2362070ead0afcef1e6c2ca784083ddb01ba51a 
>   src/slave/containerizer/fetcher.cpp 
> 4ac9149980cf7f013b318218a1b29369c5dcff17 
> 
> Diff: https://reviews.apache.org/r/41780/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 41780: Changed ContainerLogger and Fetcher to not duplicate FDs.

2016-01-13 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41780/
---

(Updated Jan. 13, 2016, 6:12 p.m.)


Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Artem 
Harutyunyan.


Changes
---

Tweaked a comment.  + Rebase.


Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136


Repository: mesos


Description
---

This change shifts the burden of FD lifecycle management away from 
ContainerLogger module writers.
This change also cleans up the Fetcher code slightly.


Diffs (updated)
-

  include/mesos/slave/container_logger.hpp 
a2362070ead0afcef1e6c2ca784083ddb01ba51a 
  src/slave/containerizer/fetcher.cpp 4ac9149980cf7f013b318218a1b29369c5dcff17 

Diff: https://reviews.apache.org/r/41780/diff/


Testing
---

make check


Thanks,

Joseph Wu



Re: Review Request 41780: Changed ContainerLogger and Fetcher to not duplicate FDs.

2016-01-13 Thread Benjamin Hindman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41780/#review114406
---

Ship it!


Ship It!

- Benjamin Hindman


On Jan. 14, 2016, 2:12 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41780/
> ---
> 
> (Updated Jan. 14, 2016, 2:12 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Artem 
> Harutyunyan.
> 
> 
> Bugs: MESOS-4136
> https://issues.apache.org/jira/browse/MESOS-4136
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change shifts the burden of FD lifecycle management away from 
> ContainerLogger module writers.
> This change also cleans up the Fetcher code slightly.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/container_logger.hpp 
> a2362070ead0afcef1e6c2ca784083ddb01ba51a 
>   src/slave/containerizer/fetcher.cpp 
> 4ac9149980cf7f013b318218a1b29369c5dcff17 
> 
> Diff: https://reviews.apache.org/r/41780/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 41780: Changed ContainerLogger and Fetcher to not duplicate FDs.

2016-01-05 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41780/
---

(Updated Jan. 5, 2016, 9:32 a.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
---

Shorten summary.


Summary (updated)
-

Changed ContainerLogger and Fetcher to not duplicate FDs.


Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136


Repository: mesos


Description
---

This change shifts the burden of FD lifecycle management away from 
ContainerLogger module writers.
This change also cleans up the Fetcher code slightly.


Diffs
-

  include/mesos/slave/container_logger.hpp 
a2362070ead0afcef1e6c2ca784083ddb01ba51a 
  src/slave/containerizer/fetcher.cpp 4ac9149980cf7f013b318218a1b29369c5dcff17 

Diff: https://reviews.apache.org/r/41780/diff/


Testing
---

make check


Thanks,

Joseph Wu