Re: Review Request 41814: Unified Container: Created ContainerConfig protobuf.

2016-01-11 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41814/
---

(Updated Jan. 11, 2016, 12:13 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4240
https://issues.apache.org/jira/browse/MESOS-4240


Repository: mesos


Description
---

Unified Container: Created ContainerConfig protobuf.


Diffs (updated)
-

  include/mesos/slave/isolator.proto d2032adf9336119ed8e1ff3c813d657d70331b67 

Diff: https://reviews.apache.org/r/41814/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 41814: Unified Container: Created ContainerConfig protobuf.

2016-01-08 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41814/
---

(Updated Jan. 8, 2016, 10:17 a.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4240
https://issues.apache.org/jira/browse/MESOS-4240


Repository: mesos


Description
---

Unified Container: Created ContainerConfig protobuf.


Diffs (updated)
-

  include/mesos/slave/isolator.proto d2032adf9336119ed8e1ff3c813d657d70331b67 

Diff: https://reviews.apache.org/r/41814/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 41814: Unified Container: Created ContainerConfig protobuf.

2016-01-07 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41814/#review113344
---

Ship it!



include/mesos/slave/isolator.proto (line 21)


Let me move `package mesos.slave` to the top (above 'import's)



include/mesos/slave/isolator.proto (line 77)


```
The user the task will be run as.
```


- Jie Yu


On Jan. 6, 2016, 11:40 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41814/
> ---
> 
> (Updated Jan. 6, 2016, 11:40 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4240
> https://issues.apache.org/jira/browse/MESOS-4240
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Unified Container: Created ContainerConfig protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/isolator.proto d2032adf9336119ed8e1ff3c813d657d70331b67 
> 
> Diff: https://reviews.apache.org/r/41814/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>