Re: Review Request 41862: Fix containerizer-internals Posix launcher TBD.

2016-07-09 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41862/#review141518
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Jan. 5, 2016, 2:11 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41862/
> ---
> 
> (Updated Jan. 5, 2016, 2:11 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4268
> https://issues.apache.org/jira/browse/MESOS-4268
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix containerizer-internals Posix launcher TBD.
> 
> 
> Diffs
> -
> 
>   docs/containerizer-internals.md 14c4c6ce5ed2a28defb7d6623c45ee337f1e6c3c 
> 
> Diff: https://reviews.apache.org/r/41862/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 41862: Fix containerizer-internals Posix launcher TBD.

2016-01-04 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41862/#review112639
---

Ship it!


Ship It!


docs/containerizer-internals.md (line 115)


I don't think we need (TBD) here anymore.


- Timothy Chen


On Jan. 3, 2016, 10:24 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41862/
> ---
> 
> (Updated Jan. 3, 2016, 10:24 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4268
> https://issues.apache.org/jira/browse/MESOS-4268
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix containerizer-internals Posix launcher TBD.
> 
> 
> Diffs
> -
> 
>   docs/containerizer-internals.md f620c32cdd4dd7cf6f245fad4e50925531cb4a39 
> 
> Diff: https://reviews.apache.org/r/41862/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 41862: Fix containerizer-internals Posix launcher TBD.

2016-01-04 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41862/
---

(Updated Jan. 5, 2016, 2:11 a.m.)


Review request for mesos, Jie Yu and Timothy Chen.


Changes
---

Address @tnachen comments.


Bugs: MESOS-4268
https://issues.apache.org/jira/browse/MESOS-4268


Repository: mesos


Description
---

Fix containerizer-internals Posix launcher TBD.


Diffs (updated)
-

  docs/containerizer-internals.md 14c4c6ce5ed2a28defb7d6623c45ee337f1e6c3c 

Diff: https://reviews.apache.org/r/41862/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 41862: Fix containerizer-internals Posix launcher TBD.

2016-01-04 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41862/#review112774
---


Patch looks great!

Reviews applied: [41862]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 5, 2016, 2:11 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41862/
> ---
> 
> (Updated Jan. 5, 2016, 2:11 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4268
> https://issues.apache.org/jira/browse/MESOS-4268
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix containerizer-internals Posix launcher TBD.
> 
> 
> Diffs
> -
> 
>   docs/containerizer-internals.md 14c4c6ce5ed2a28defb7d6623c45ee337f1e6c3c 
> 
> Diff: https://reviews.apache.org/r/41862/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 41862: Fix containerizer-internals Posix launcher TBD.

2016-01-03 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41862/#review112456
---


Patch looks great!

Reviews applied: [41862]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 3, 2016, 10:24 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41862/
> ---
> 
> (Updated Jan. 3, 2016, 10:24 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4268
> https://issues.apache.org/jira/browse/MESOS-4268
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix containerizer-internals Posix launcher TBD.
> 
> 
> Diffs
> -
> 
>   docs/containerizer-internals.md f620c32cdd4dd7cf6f245fad4e50925531cb4a39 
> 
> Diff: https://reviews.apache.org/r/41862/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>