Re: Review Request 41881: Provided constexpr Duration min and max values.

2016-01-11 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41881/#review113821 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 4, 2016, 6:43

Re: Review Request 41881: Provided constexpr Duration min and max values.

2016-01-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41881/ --- (Updated Jan. 4, 2016, 6:43 p.m.) Review request for mesos, Joris Van

Re: Review Request 41881: Provided constexpr Duration min and max values.

2016-01-04 Thread Benjamin Bannier
> On Jan. 4, 2016, 6:26 p.m., Joris Van Remoortere wrote: > > Looks good. How did you choose the particular functions to make constexpr. > > Why not the units for example? or others? The goal was to provide `constexpr` versions of `Duration::min`, `Duration::max`, and `Duration::zero`. The

Re: Review Request 41881: Provided constexpr Duration min and max values.

2016-01-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41881/#review112543 --- Ship it! Ship It! - Till Toenshoff On Jan. 4, 2016, 10:49

Re: Review Request 41881: Provided constexpr Duration min and max values.

2016-01-04 Thread Benjamin Bannier
> On Jan. 4, 2016, 6:26 p.m., Joris Van Remoortere wrote: > > Looks good. How did you choose the particular functions to make constexpr. > > Why not the units for example? or others? > > Benjamin Bannier wrote: > The goal was to provide `constexpr` versions of `Duration::min`, >

Re: Review Request 41881: Provided constexpr Duration min and max values.

2016-01-04 Thread Joris Van Remoortere
> On Jan. 4, 2016, 6:26 p.m., Joris Van Remoortere wrote: > > Looks good. How did you choose the particular functions to make constexpr. > > Why not the units for example? or others? > > Benjamin Bannier wrote: > The goal was to provide `constexpr` versions of `Duration::min`, >

Re: Review Request 41881: Provided constexpr Duration min and max values.

2016-01-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41881/#review112754 --- Patch looks great! Reviews applied: [41881] Passed command:

Re: Review Request 41881: Provided constexpr Duration min and max values.

2016-01-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41881/#review112609 --- Looks good. How did you choose the particular functions to make