Re: Review Request 41961: Added an HTTP decode response method.

2016-01-18 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41961/#review115076 --- Ship it! Ship It! - Timothy Chen On Jan. 17, 2016, 9:50 p.m.,

Re: Review Request 41961: Added an HTTP decode response method.

2016-01-17 Thread Jie Yu
> On Jan. 8, 2016, 9:31 p.m., Timothy Chen wrote: > > 3rdparty/libprocess/src/http.cpp, line 707 > > > > > > Why don't we return the failure message? This is a limitation of the decoder currently. - Jie

Re: Review Request 41961: Added an HTTP decode response method.

2016-01-17 Thread Jie Yu
> On Jan. 8, 2016, 9:30 p.m., Timothy Chen wrote: > > 3rdparty/libprocess/src/http.cpp, line 714 > > > > > > Should we also comment that we only return the first response even if > > there are multiples? Changed

Re: Review Request 41961: Added an HTTP decode response method.

2016-01-17 Thread Jie Yu
> On Jan. 8, 2016, 9:30 p.m., Timothy Chen wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 718 > > > > > > bmahler might have different say on this, as he was proposing that the > > comment style

Re: Review Request 41961: Added an HTTP decode response method.

2016-01-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41961/ --- (Updated Jan. 17, 2016, 9:50 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41961: Added an HTTP decode response method.

2016-01-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41961/ --- (Updated Jan. 13, 2016, 6:36 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41961: Added an HTTP decode response method.

2016-01-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41961/#review113539 --- 3rdparty/libprocess/include/process/http.hpp (line 718)

Re: Review Request 41961: Added an HTTP decode response method.

2016-01-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41961/#review113540 --- 3rdparty/libprocess/src/http.cpp (line 707)

Re: Review Request 41961: Added an HTTP decode response method.

2016-01-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41961/#review113009 --- Patch looks great! Reviews applied: [41956, 41957, 41960, 41961]