Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

2016-01-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41962/ --- (Updated Jan. 23, 2016, 1:13 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

2016-01-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41962/ --- (Updated Jan. 19, 2016, 7:42 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

2016-01-14 Thread Joseph Wu
> On Jan. 13, 2016, 9:02 p.m., Benjamin Hindman wrote: > > src/tests/container_logger_tests.cpp, lines 153-154 > > > > > > Ugh, using something we passed in as `Owned` above? Have we still not > > cleaned up this

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

2016-01-13 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41962/#review114414 --- src/tests/container_logger_tests.cpp (lines 153 - 154)

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

2016-01-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41962/ --- (Updated Jan. 12, 2016, 2:31 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

2016-01-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41962/#review113538 --- src/tests/container_logger_tests.cpp (line 222)

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

2016-01-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41962/ --- (Updated Jan. 8, 2016, 4:24 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

2016-01-08 Thread Jojy Varghese
> On Jan. 6, 2016, 7:32 p.m., Jojy Varghese wrote: > > src/tests/container_logger_tests.cpp, line 158 > > > > > > Can we have this as : > > > > ``` > > Shared docker(new MockDocker(...)); > > > >

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

2016-01-08 Thread Joseph Wu
> On Jan. 8, 2016, 1:29 p.m., Timothy Chen wrote: > > src/tests/container_logger_tests.cpp, line 222 > > > > > > Do we need to check that the correct container id is passed? It wouldn't hurt. I'll add it to both

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

2016-01-07 Thread Joseph Wu
> On Jan. 6, 2016, 11:32 a.m., Jojy Varghese wrote: > > src/tests/container_logger_tests.cpp, line 95 > > > > > > What is the ownership semantics of this pointer? Here and other places. Other than the `Docker`