Re: Review Request 41963: Logger Module: Implement ContainerLogger recovery.

2016-01-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41963/ --- (Updated Jan. 19, 2016, 7:41 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41963: Logger Module: Implement ContainerLogger recovery.

2016-01-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41963/#review113045 --- Patch looks great! Reviews applied: [42052, 41779, 41780, 41781,

Re: Review Request 41963: Logger Module: Implement ContainerLogger recovery.

2016-01-13 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41963/#review114411 --- Ship it! Ship It! - Benjamin Hindman On Jan. 12, 2016, 10:31

Re: Review Request 41963: Logger Module: Implement ContainerLogger recovery.

2016-01-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41963/ --- (Updated Jan. 12, 2016, 2:31 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41963: Logger Module: Implement ContainerLogger recovery.

2016-01-08 Thread Jojy Varghese
> On Jan. 6, 2016, 7:21 p.m., Jojy Varghese wrote: > > src/slave/containerizer/docker.cpp, line 701 > > > > > > Do you need all the variables on the stack to be passed to the capture? > > Maybe just executorInfo ?

Re: Review Request 41963: Logger Module: Implement ContainerLogger recovery.

2016-01-07 Thread Joseph Wu
> On Jan. 6, 2016, 11:21 a.m., Jojy Varghese wrote: > > src/slave/containerizer/docker.cpp, line 701 > > > > > > Do you need all the variables on the stack to be passed to the capture? > > Maybe just executorInfo ?

Re: Review Request 41963: Logger Module: Implement ContainerLogger recovery.

2016-01-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41963/#review113117 --- src/slave/containerizer/docker.cpp (line 701)