Re: Review Request 42036: Windows: Added `slave/flags.cpp` to Windows build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42036/#review123834 --- Ship it! Ship It! - Michael Park On March 11, 2016, 9:51 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42036/ > --- > > (Updated March 11, 2016, 9:51 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, and > Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > Windows: Added `slave/flags.cpp` to Windows build. > > > Diffs > - > > src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f > > Diff: https://reviews.apache.org/r/42036/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 42036: Windows: Added `slave/flags.cpp` to Windows build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42036/ --- (Updated March 11, 2016, 9:51 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, and Joris Van Remoortere. Repository: mesos Description --- Windows: Added `slave/flags.cpp` to Windows build. Diffs (updated) - src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f Diff: https://reviews.apache.org/r/42036/diff/ Testing --- Thanks, Alex Clemmer
Re: Review Request 42036: Windows: Added `slave/flags.cpp` to Windows build.
> On March 1, 2016, 10:10 a.m., Alex Clemmer wrote: > > Ship It! Ah, oops, sorry folks. :( Meant to click this for a different review. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42036/#review121412 --- On Jan. 7, 2016, 9:47 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42036/ > --- > > (Updated Jan. 7, 2016, 9:47 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, and > Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > Windows: Added `slave/flags.cpp` to Windows build. > > > Diffs > - > > src/CMakeLists.txt 81afdc6c3e9b062efb181b2f92a9185bdd4acfb1 > > Diff: https://reviews.apache.org/r/42036/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 42036: Windows: Added `slave/flags.cpp` to Windows build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42036/#review121412 --- Ship it! Ship It! - Alex Clemmer On Jan. 7, 2016, 9:47 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42036/ > --- > > (Updated Jan. 7, 2016, 9:47 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, and > Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > Windows: Added `slave/flags.cpp` to Windows build. > > > Diffs > - > > src/CMakeLists.txt 81afdc6c3e9b062efb181b2f92a9185bdd4acfb1 > > Diff: https://reviews.apache.org/r/42036/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 42036: Windows: Added `slave/flags.cpp` to Windows build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42036/#review113345 --- Bad patch! Reviews applied: [42036] Failed command: ./support/apply-review.sh -n -r 42036 Error: 2016-01-07 22:19:13 URL:https://reviews.apache.org/r/42036/diff/raw/ [570/570] -> "42036.patch" [1] error: patch failed: src/CMakeLists.txt:197 error: src/CMakeLists.txt: patch does not apply - Mesos ReviewBot On Jan. 7, 2016, 9:47 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42036/ > --- > > (Updated Jan. 7, 2016, 9:47 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, and > Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > Windows: Added `slave/flags.cpp` to Windows build. > > > Diffs > - > > src/CMakeLists.txt 81afdc6c3e9b062efb181b2f92a9185bdd4acfb1 > > Diff: https://reviews.apache.org/r/42036/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
