Re: Review Request 42172: Add documentation for logging and ContainerLogger.

2016-01-22 Thread Joseph Wu 


> On Jan. 22, 2016, 11:16 a.m., Neil Conway wrote:
> > Can we also mention the common GLOG configuration options? For example, 
> > `GLOG_v`.

Besides `GLOG_v`, what else would you suggest?  There are quite a few, but I've 
only ever set this one specifically.

Note: That one is mentioned here:
https://reviews.apache.org/r/42172/diff/5#file1202582line125


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42172/#review115906
---


On Jan. 19, 2016, 7:41 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42172/
> ---
> 
> (Updated Jan. 19, 2016, 7:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-4206
> https://issues.apache.org/jira/browse/MESOS-4206
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moves (and updates) logging flags from configuration.md into the new 
> logging.md.
> 
> Add documentation for the ContainerLogger.
> Adds documentation about logging in Master/Agent/Framework and the 
> ContainerLogger.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 1834992907a29f571200fe8422f7c26eaac7d5a0 
>   docs/home.md ff797fb050d710283fa7e648515ec75779e58f65 
>   docs/logging.md PRE-CREATION 
>   docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025 
>   src/logging/flags.cpp b321c28492dbc9711b937f6cd9a8423ce557957f 
> 
> Diff: https://reviews.apache.org/r/42172/diff/
> 
> 
> Testing
> ---
> 
> Previewed on GitHub and via:
> ```
> docker build -t mesos/website support/site-docker
> docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

2016-01-22 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42172/#review115906
---


Can we also mention the common GLOG configuration options? For example, 
`GLOG_v`.

- Neil Conway


On Jan. 20, 2016, 3:41 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42172/
> ---
> 
> (Updated Jan. 20, 2016, 3:41 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-4206
> https://issues.apache.org/jira/browse/MESOS-4206
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moves (and updates) logging flags from configuration.md into the new 
> logging.md.
> 
> Add documentation for the ContainerLogger.
> Adds documentation about logging in Master/Agent/Framework and the 
> ContainerLogger.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 1834992907a29f571200fe8422f7c26eaac7d5a0 
>   docs/home.md ff797fb050d710283fa7e648515ec75779e58f65 
>   docs/logging.md PRE-CREATION 
>   docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025 
>   src/logging/flags.cpp b321c28492dbc9711b937f6cd9a8423ce557957f 
> 
> Diff: https://reviews.apache.org/r/42172/diff/
> 
> 
> Testing
> ---
> 
> Previewed on GitHub and via:
> ```
> docker build -t mesos/website support/site-docker
> docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

2016-01-19 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42172/
---

(Updated Jan. 19, 2016, 10:35 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil Conway.


Changes
---

Reverted change in summary/description due to change in apply-reviews.py


Summary (updated)
-

Add documentation for logging and ContainerLogger.


Bugs: MESOS-4206
https://issues.apache.org/jira/browse/MESOS-4206


Repository: mesos


Description (updated)
---

Moves (and updates) logging flags from configuration.md into the new logging.md.

Add documentation for the ContainerLogger.
Adds documentation about logging in Master/Agent/Framework and the 
ContainerLogger.


Diffs
-

  docs/configuration.md 1834992907a29f571200fe8422f7c26eaac7d5a0 
  docs/home.md ff797fb050d710283fa7e648515ec75779e58f65 
  docs/logging.md PRE-CREATION 
  docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025 

Diff: https://reviews.apache.org/r/42172/diff/


Testing
---

Previewed on GitHub and via:
```
docker build -t mesos/website support/site-docker
docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
```


Thanks,

Joseph Wu

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

2016-01-19 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42172/
---

(Updated Jan. 19, 2016, 11:58 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil Conway.


Changes
---

Mirror updates to logging flag docs to the actual flag's help.
Add blurb in new doc about /logging/toggle.


Bugs: MESOS-4206
https://issues.apache.org/jira/browse/MESOS-4206


Repository: mesos


Description
---

Moves (and updates) logging flags from configuration.md into the new logging.md.

Add documentation for the ContainerLogger.
Adds documentation about logging in Master/Agent/Framework and the 
ContainerLogger.


Diffs (updated)
-

  docs/configuration.md 1834992907a29f571200fe8422f7c26eaac7d5a0 
  docs/home.md ff797fb050d710283fa7e648515ec75779e58f65 
  docs/logging.md PRE-CREATION 
  docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025 
  src/logging/flags.cpp b321c28492dbc9711b937f6cd9a8423ce557957f 

Diff: https://reviews.apache.org/r/42172/diff/


Testing
---

Previewed on GitHub and via:
```
docker build -t mesos/website support/site-docker
docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
```


Thanks,

Joseph Wu

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

2016-01-19 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42172/
---

(Updated Jan. 19, 2016, 7:41 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil Conway.


Changes
---

Rename "rotating" to "logrotate" and add the new logrotate flags.


Bugs: MESOS-4206
https://issues.apache.org/jira/browse/MESOS-4206


Repository: mesos


Description
---

Moves (and updates) logging flags from configuration.md into the new logging.md.

Add documentation for the ContainerLogger.
Adds documentation about logging in Master/Agent/Framework and the 
ContainerLogger.


Diffs (updated)
-

  docs/configuration.md 1834992907a29f571200fe8422f7c26eaac7d5a0 
  docs/home.md ff797fb050d710283fa7e648515ec75779e58f65 
  docs/logging.md PRE-CREATION 
  docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025 
  src/logging/flags.cpp b321c28492dbc9711b937f6cd9a8423ce557957f 

Diff: https://reviews.apache.org/r/42172/diff/


Testing
---

Previewed on GitHub and via:
```
docker build -t mesos/website support/site-docker
docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
```


Thanks,

Joseph Wu

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

2016-01-19 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42172/#review115374
---


Patch looks great!

Reviews applied: [42172]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 20, 2016, 3:41 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42172/
> ---
> 
> (Updated Jan. 20, 2016, 3:41 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-4206
> https://issues.apache.org/jira/browse/MESOS-4206
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moves (and updates) logging flags from configuration.md into the new 
> logging.md.
> 
> Add documentation for the ContainerLogger.
> Adds documentation about logging in Master/Agent/Framework and the 
> ContainerLogger.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 1834992907a29f571200fe8422f7c26eaac7d5a0 
>   docs/home.md ff797fb050d710283fa7e648515ec75779e58f65 
>   docs/logging.md PRE-CREATION 
>   docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025 
>   src/logging/flags.cpp b321c28492dbc9711b937f6cd9a8423ce557957f 
> 
> Diff: https://reviews.apache.org/r/42172/diff/
> 
> 
> Testing
> ---
> 
> Previewed on GitHub and via:
> ```
> docker build -t mesos/website support/site-docker
> docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

2016-01-13 Thread Benjamin Hindman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42172/#review114415
---

Ship it!


Ship It!

- Benjamin Hindman


On Jan. 12, 2016, 7:24 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42172/
> ---
> 
> (Updated Jan. 12, 2016, 7:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-4206
> https://issues.apache.org/jira/browse/MESOS-4206
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moves (and updates) logging flags from `configuration.md` into the new 
> `logging.md`.
> Adds documentation about logging in Master/Agent/Framework and the 
> `ContainerLogger`.
> 
> Allows the doc-linking pattern of `[link text](other_doc.md#Link-to-text)`.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md cbe7f5a338a0fc350c4b6c0e2f1f48bd0869ac34 
>   docs/home.md 344c5617dfb003453fa17974500d44a8f766cb16 
>   docs/logging.md PRE-CREATION 
>   docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025 
>   site/Rakefile 94833488c8e29f9b07e3cab3c8adce223f685679 
> 
> Diff: https://reviews.apache.org/r/42172/diff/
> 
> 
> Testing
> ---
> 
> Previewed on GitHub and via:
> ```
> docker build -t mesos/website support/site-docker
> docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

2016-01-12 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42172/#review114018
---



docs/logging.md (line 21)


Given that we use "module" in a different sense below, I'd avoid calling 
glog a "module". How about "Google's logging package" or "the Google logging 
package"?



docs/logging.md (line 39)


Do we want  or back-ticks? Back-ticks would probably be more 
consistent with the other doc pages.



docs/logging.md (line 77)


"that logs"



docs/logging.md (line 87)


This is worded a little confusingly. Following the other flags, I'd say 
what the flag does first, and then say what the default value is.



docs/logging.md (line 98)


For consistency, should be something like "Location of the externally 
managed log file." Also, maybe clarify that this doesn't actually control 
_where_ the log file is written; it is just for telling Mesos where (a 
different mechanism) has arranged for the file to appear.



docs/logging.md (line 126)


Maybe clarify that `ContainerLogger` is a Mesos module, and link to the 
module documentation immediately? (I know we link below but we could make it 
more obvious.)


Overall, looks good!

- Neil Conway


On Jan. 12, 2016, 1:07 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42172/
> ---
> 
> (Updated Jan. 12, 2016, 1:07 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-4206
> https://issues.apache.org/jira/browse/MESOS-4206
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moves (and updates) logging flags from `configuration.md` into the new 
> `logging.md`.
> Adds documentation about logging in Master/Agent/Framework and the 
> `ContainerLogger`.
> 
> Allows the doc-linking pattern of `[link text](other_doc.md#Link-to-text)`.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md cbe7f5a338a0fc350c4b6c0e2f1f48bd0869ac34 
>   docs/home.md 344c5617dfb003453fa17974500d44a8f766cb16 
>   docs/logging.md PRE-CREATION 
>   docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025 
>   site/Rakefile 94833488c8e29f9b07e3cab3c8adce223f685679 
> 
> Diff: https://reviews.apache.org/r/42172/diff/
> 
> 
> Testing
> ---
> 
> Previewed on GitHub and via:
> ```
> docker build -t mesos/website support/site-docker
> docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

2016-01-12 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42172/#review114040
---

Ship it!


Ship It!

- Neil Conway


On Jan. 12, 2016, 7:24 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42172/
> ---
> 
> (Updated Jan. 12, 2016, 7:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-4206
> https://issues.apache.org/jira/browse/MESOS-4206
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moves (and updates) logging flags from `configuration.md` into the new 
> `logging.md`.
> Adds documentation about logging in Master/Agent/Framework and the 
> `ContainerLogger`.
> 
> Allows the doc-linking pattern of `[link text](other_doc.md#Link-to-text)`.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md cbe7f5a338a0fc350c4b6c0e2f1f48bd0869ac34 
>   docs/home.md 344c5617dfb003453fa17974500d44a8f766cb16 
>   docs/logging.md PRE-CREATION 
>   docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025 
>   site/Rakefile 94833488c8e29f9b07e3cab3c8adce223f685679 
> 
> Diff: https://reviews.apache.org/r/42172/diff/
> 
> 
> Testing
> ---
> 
> Previewed on GitHub and via:
> ```
> docker build -t mesos/website support/site-docker
> docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

2016-01-12 Thread Joseph Wu 


> On Jan. 12, 2016, 10:03 a.m., Neil Conway wrote:
> > docs/logging.md, line 39
> > 
> >
> > Do we want  or back-ticks? Back-ticks would probably be more 
> > consistent with the other doc pages.

This is an unfortunate side-effect of not being able to mix HTML and markdown :(
Backticks don't render as `` inside a `` (I've tried it).


> On Jan. 12, 2016, 10:03 a.m., Neil Conway wrote:
> > docs/logging.md, line 21
> > 
> >
> > Given that we use "module" in a different sense below, I'd avoid 
> > calling glog a "module". How about "Google's logging package" or "the 
> > Google logging package"?

That's the official name :P
I think I'll go with "Google's logging library".


> On Jan. 12, 2016, 10:03 a.m., Neil Conway wrote:
> > docs/logging.md, line 126
> > 
> >
> > Maybe clarify that `ContainerLogger` is a Mesos module, and link to the 
> > module documentation immediately? (I know we link below but we could make 
> > it more obvious.)

Moved the link up.  On the website, the word "Module" shows up in big font, so 
that should be fairly obvious.

Note: I added some more text to the "Writing a Custom ContainerLogger", mostly 
to reiterate some of the design-decisions/comments inside the interface.


> On Jan. 12, 2016, 10:03 a.m., Neil Conway wrote:
> > docs/logging.md, line 98
> > 
> >
> > For consistency, should be something like "Location of the externally 
> > managed log file." Also, maybe clarify that this doesn't actually control 
> > _where_ the log file is written; it is just for telling Mesos where (a 
> > different mechanism) has arranged for the file to appear.

Also added some more cross-flag clarification here.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42172/#review114018
---


On Jan. 12, 2016, 11:24 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42172/
> ---
> 
> (Updated Jan. 12, 2016, 11:24 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-4206
> https://issues.apache.org/jira/browse/MESOS-4206
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moves (and updates) logging flags from `configuration.md` into the new 
> `logging.md`.
> Adds documentation about logging in Master/Agent/Framework and the 
> `ContainerLogger`.
> 
> Allows the doc-linking pattern of `[link text](other_doc.md#Link-to-text)`.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md cbe7f5a338a0fc350c4b6c0e2f1f48bd0869ac34 
>   docs/home.md 344c5617dfb003453fa17974500d44a8f766cb16 
>   docs/logging.md PRE-CREATION 
>   docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025 
>   site/Rakefile 94833488c8e29f9b07e3cab3c8adce223f685679 
> 
> Diff: https://reviews.apache.org/r/42172/diff/
> 
> 
> Testing
> ---
> 
> Previewed on GitHub and via:
> ```
> docker build -t mesos/website support/site-docker
> docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

2016-01-12 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42172/
---

(Updated Jan. 12, 2016, 11:24 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil Conway.


Changes
---

Reworded a couple of places.  Expanded on the "--external_log_file", 
"--initialize_driver_logging", and "Writing a Custom ContainerLogger" sections


Bugs: MESOS-4206
https://issues.apache.org/jira/browse/MESOS-4206


Repository: mesos


Description
---

Moves (and updates) logging flags from `configuration.md` into the new 
`logging.md`.
Adds documentation about logging in Master/Agent/Framework and the 
`ContainerLogger`.

Allows the doc-linking pattern of `[link text](other_doc.md#Link-to-text)`.


Diffs (updated)
-

  docs/configuration.md cbe7f5a338a0fc350c4b6c0e2f1f48bd0869ac34 
  docs/home.md 344c5617dfb003453fa17974500d44a8f766cb16 
  docs/logging.md PRE-CREATION 
  docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025 
  site/Rakefile 94833488c8e29f9b07e3cab3c8adce223f685679 

Diff: https://reviews.apache.org/r/42172/diff/


Testing
---

Previewed on GitHub and via:
```
docker build -t mesos/website support/site-docker
docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
```


Thanks,

Joseph Wu

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

2016-01-12 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42172/#review114092
---


Patch looks great!

Reviews applied: [42172]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 12, 2016, 7:24 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42172/
> ---
> 
> (Updated Jan. 12, 2016, 7:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-4206
> https://issues.apache.org/jira/browse/MESOS-4206
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moves (and updates) logging flags from `configuration.md` into the new 
> `logging.md`.
> Adds documentation about logging in Master/Agent/Framework and the 
> `ContainerLogger`.
> 
> Allows the doc-linking pattern of `[link text](other_doc.md#Link-to-text)`.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md cbe7f5a338a0fc350c4b6c0e2f1f48bd0869ac34 
>   docs/home.md 344c5617dfb003453fa17974500d44a8f766cb16 
>   docs/logging.md PRE-CREATION 
>   docs/modules.md 1aad8e0958554c0219a287dffd6c6fb925edb025 
>   site/Rakefile 94833488c8e29f9b07e3cab3c8adce223f685679 
> 
> Diff: https://reviews.apache.org/r/42172/diff/
> 
> 
> Testing
> ---
> 
> Previewed on GitHub and via:
> ```
> docker build -t mesos/website support/site-docker
> docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>