Re: Review Request 42184: Introduced `FUTURE_HTTP_*` for filtering HTTP based events.

2016-01-26 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42184/#review116481
---


Fix it, then Ship it!





src/tests/mesos.hpp (line 1511)


why do you need a default?



src/tests/mesos.hpp (line 1532)


why do you need a default?



src/tests/mesos.hpp (line 1582)


ditto. why default?



src/tests/mesos.hpp (line 1600)


why default?



src/tests/mesos.hpp (line 1638)


ditto.



src/tests/mesos.hpp (line 1656)


ditto.


- Vinod Kone


On Jan. 22, 2016, 8:17 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42184/
> ---
> 
> (Updated Jan. 22, 2016, 8:17 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4425
> https://issues.apache.org/jira/browse/MESOS-4425
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces `FUTURE_HTTP_*` for filtering HTTP based events 
> similar to the already existing filters for Messages/Dispatch events. Also, 
> added `FUTURE_HTTP_CALL_*` for union based protobufs.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac 
> 
> Diff: https://reviews.apache.org/r/42184/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 42184: Introduced `FUTURE_HTTP_*` for filtering HTTP based events.

2016-01-26 Thread Anand Mazumdar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42184/
---

(Updated Jan. 27, 2016, 1:17 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comments from Vinod


Bugs: MESOS-4425
https://issues.apache.org/jira/browse/MESOS-4425


Repository: mesos


Description
---

This change introduces `FUTURE_HTTP_*` for filtering HTTP based events similar 
to the already existing filters for Messages/Dispatch events. Also, added 
`FUTURE_HTTP_CALL_*` for union based protobufs.


Diffs (updated)
-

  src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b 

Diff: https://reviews.apache.org/r/42184/diff/


Testing (updated)
---

make check + added tests in r42186 for testing recovery of HTTP based executors.


Thanks,

Anand Mazumdar



Re: Review Request 42184: Introduced `FUTURE_HTTP_*` for filtering HTTP based events.

2016-01-22 Thread Anand Mazumdar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42184/
---

(Updated Jan. 22, 2016, 8:17 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Updated JIRA


Bugs: MESOS-4425
https://issues.apache.org/jira/browse/MESOS-4425


Repository: mesos


Description
---

This change introduces `FUTURE_HTTP_*` for filtering HTTP based events similar 
to the already existing filters for Messages/Dispatch events. Also, added 
`FUTURE_HTTP_CALL_*` for union based protobufs.


Diffs
-

  src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac 

Diff: https://reviews.apache.org/r/42184/diff/


Testing
---

make check


Thanks,

Anand Mazumdar