Re: Review Request 42211: Added filters to disable NetClsIsolator tests in case cgroups is not present or the net_cls subsystem is disable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42211/#review114273 --- Bad patch! Reviews applied: [42047] Failed command: ./support/apply-review.sh -n -r 42047 Error: 2016-01-13 20:49:34 URL:https://reviews.apache.org/r/42047/diff/raw/ [9619/9619] -> "42047.patch" [1] Total errors found: 0 Checking 2 files Error: Commit message summary (the first line) must not exceed 72 characters. - Mesos ReviewBot On Jan. 13, 2016, 5:52 p.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42211/ > --- > > (Updated Jan. 13, 2016, 5:52 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4262 > https://issues.apache.org/jira/browse/MESOS-4262 > > > Repository: mesos > > > Description > --- > > Added filters to disable NetClsIsolator tests in case cgroups is not present > or the net_cls subsystem is disable. > > > Diffs > - > > src/tests/environment.cpp 36f0ad0b739559e5c883d72585731944da4283cf > > Diff: https://reviews.apache.org/r/42211/diff/ > > > Testing > --- > > make check > > * Tested the filter by disabling cls_group.ko (module for net_cls cgroup). > The NetClsIsolator tests were correctly disabled when I ran make check with > the filter set to NetClsIsolatorTest.ROOT_CGROUPS_NetClsIsolate > > > Thanks, > > Avinash sridharan > >
Re: Review Request 42211: Added filters to disable NetClsIsolator tests in case cgroups is not present or the net_cls subsystem is disable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42211/ --- (Updated Jan. 13, 2016, 5:52 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-4262 https://issues.apache.org/jira/browse/MESOS-4262 Repository: mesos Description --- Added filters to disable NetClsIsolator tests in case cgroups is not present or the net_cls subsystem is disable. Diffs (updated) - src/tests/environment.cpp 36f0ad0b739559e5c883d72585731944da4283cf Diff: https://reviews.apache.org/r/42211/diff/ Testing --- make check * Tested the filter by disabling cls_group.ko (module for net_cls cgroup). The NetClsIsolator tests were correctly disabled when I ran make check with the filter set to NetClsIsolatorTest.ROOT_CGROUPS_NetClsIsolate Thanks, Avinash sridharan
Re: Review Request 42211: Added filters to disable NetClsIsolator tests in case cgroups is not present or the net_cls subsystem is disable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42211/ --- (Updated Jan. 12, 2016, 10:05 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-4262 https://issues.apache.org/jira/browse/MESOS-4262 Repository: mesos Description --- Added filters to disable NetClsIsolator tests in case cgroups is not present or the net_cls subsystem is disable. Diffs - src/tests/environment.cpp 36f0ad0b739559e5c883d72585731944da4283cf Diff: https://reviews.apache.org/r/42211/diff/ Testing --- make check * Tested the filter by disabling cls_group.ko (module for net_cls cgroup). The NetClsIsolator tests were correctly disabled when I ran make check with the filter set to NetClsIsolatorTest.ROOT_CGROUPS_NetClsIsolate Thanks, Avinash sridharan