Re: Review Request 42361: Added dynamic reservation test with no principal.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42361/#review115269
---



src/tests/reservation_tests.cpp (lines 1762 - 1765)


Can we just initialize it to `DEFAULT_FRAMEWORK_INFO` and __unset__ the 
principal instead?



src/tests/reservation_tests.cpp (line 1831)


Can we check that we receive `unreserved` instead to make sure that nothing 
changed? Rather than "it didn't change to `dynamicallyReserved`"?


- Michael Park


On Jan. 16, 2016, 4:31 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42361/
> ---
> 
> (Updated Jan. 16, 2016, 4:31 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-4195
> https://issues.apache.org/jira/browse/MESOS-4195
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added dynamic reservation test with no principal.
> 
> Currently, we do not allow dynamic reservations without a principal. This 
> test was added to verify that framework reserve operations without a 
> principal will fail as expected.
> 
> 
> Diffs
> -
> 
>   src/tests/reservation_tests.cpp 2ea3b6e48e75f438b325211fb562db19bd3a82e0 
> 
> Diff: https://reviews.apache.org/r/42361/diff/
> 
> 
> Testing
> ---
> 
> A new test, `ReservationTest.ReservationInfoNoPrincipal`, was added, and 
> `make check` was used to test. The new test was also run with 
> `--gtest_repeat=1000 --gtest_break_on_failure=1`.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 42361: Added dynamic reservation test with no principal.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42361/#review115273
---



src/tests/reservation_tests.cpp (line 1823)


Why do we use `DEFAULT_ALLOCATION_INTERVAL` rather than 
`masterFlags.allocation_interval`? If we can just use the one from 
`masterFlags`, then we should be able to get rid of the `using` declaration at 
the top as well.


- Michael Park


On Jan. 16, 2016, 4:31 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42361/
> ---
> 
> (Updated Jan. 16, 2016, 4:31 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-4195
> https://issues.apache.org/jira/browse/MESOS-4195
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added dynamic reservation test with no principal.
> 
> Currently, we do not allow dynamic reservations without a principal. This 
> test was added to verify that framework reserve operations without a 
> principal will fail as expected.
> 
> 
> Diffs
> -
> 
>   src/tests/reservation_tests.cpp 2ea3b6e48e75f438b325211fb562db19bd3a82e0 
> 
> Diff: https://reviews.apache.org/r/42361/diff/
> 
> 
> Testing
> ---
> 
> A new test, `ReservationTest.ReservationInfoNoPrincipal`, was added, and 
> `make check` was used to test. The new test was also run with 
> `--gtest_repeat=1000 --gtest_break_on_failure=1`.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 42361: Added dynamic reservation test with no principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42361/
---

(Updated Jan. 19, 2016, 11:59 p.m.)


Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.


Changes
---

Addressed comments.


Bugs: MESOS-4195
https://issues.apache.org/jira/browse/MESOS-4195


Repository: mesos


Description
---

Added dynamic reservation test with no principal.

Currently, we do not allow dynamic reservations without a principal. This test 
was added to verify that framework reserve operations without a principal will 
fail as expected.


Diffs (updated)
-

  src/tests/reservation_tests.cpp 2ea3b6e48e75f438b325211fb562db19bd3a82e0 

Diff: https://reviews.apache.org/r/42361/diff/


Testing
---

A new test, `ReservationTest.ReservationInfoNoPrincipal`, was added, and `make 
check` was used to test. The new test was also run with `--gtest_repeat=1000 
--gtest_break_on_failure=1`.


Thanks,

Greg Mann

Re: Review Request 42361: Added dynamic reservation test with no principal.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42361/#review115283
---

Ship it!



src/tests/reservation_tests.cpp (lines 1761 - 1762)


We still should set the `role` explicitly right?

`DEFAULT_FRAMEWORK_INFO` doesn't include a `role`.



src/tests/reservation_tests.cpp (line 1786)


Can we be more specific in that this is a `ReservationInfo` with a missing 
principal, rather than just an empty `ReservationInfo`?


- Michael Park


On Jan. 19, 2016, 11:40 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42361/
> ---
> 
> (Updated Jan. 19, 2016, 11:40 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-4195
> https://issues.apache.org/jira/browse/MESOS-4195
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added dynamic reservation test with no principal.
> 
> Currently, we do not allow dynamic reservations without a principal. This 
> test was added to verify that framework reserve operations without a 
> principal will fail as expected.
> 
> 
> Diffs
> -
> 
>   src/tests/reservation_tests.cpp 2ea3b6e48e75f438b325211fb562db19bd3a82e0 
> 
> Diff: https://reviews.apache.org/r/42361/diff/
> 
> 
> Testing
> ---
> 
> A new test, `ReservationTest.ReservationInfoNoPrincipal`, was added, and 
> `make check` was used to test. The new test was also run with 
> `--gtest_repeat=1000 --gtest_break_on_failure=1`.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 42361: Added dynamic reservation test with no principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42361/
---

(Updated Jan. 20, 2016, 1:27 a.m.)


Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.


Changes
---

Introduced `createReservationInfo(None())`.


Bugs: MESOS-4195
https://issues.apache.org/jira/browse/MESOS-4195


Repository: mesos


Description
---

Added dynamic reservation test with no principal.

Currently, we do not allow dynamic reservations without a principal. This test 
was added to verify that framework reserve operations without a principal will 
fail as expected.


Diffs (updated)
-

  src/tests/reservation_tests.cpp 2ea3b6e48e75f438b325211fb562db19bd3a82e0 

Diff: https://reviews.apache.org/r/42361/diff/


Testing
---

A new test, `ReservationTest.ReservationInfoNoPrincipal`, was added, and `make 
check` was used to test. The new test was also run with `--gtest_repeat=1000 
--gtest_break_on_failure=1`.


Thanks,

Greg Mann

Re: Review Request 42361: Added dynamic reservation test with no principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42361/
---

(Updated Jan. 20, 2016, 3:42 a.m.)


Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.


Changes
---

Addressed comment.


Bugs: MESOS-4195
https://issues.apache.org/jira/browse/MESOS-4195


Repository: mesos


Description
---

Added dynamic reservation test with no principal.

Currently, we do not allow dynamic reservations without a principal. This test 
was added to verify that framework reserve operations without a principal will 
fail as expected.


Diffs (updated)
-

  src/tests/reservation_tests.cpp 2ea3b6e48e75f438b325211fb562db19bd3a82e0 

Diff: https://reviews.apache.org/r/42361/diff/


Testing
---

A new test, `ReservationTest.ReservationInfoNoPrincipal`, was added, and `make 
check` was used to test. The new test was also run with `--gtest_repeat=1000 
--gtest_break_on_failure=1`.


Thanks,

Greg Mann

Re: Review Request 42361: Added dynamic reservation test with no principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42361/
---

(Updated Jan. 19, 2016, 11:40 p.m.)


Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.


Changes
---

Addressed comments.


Bugs: MESOS-4195
https://issues.apache.org/jira/browse/MESOS-4195


Repository: mesos


Description
---

Added dynamic reservation test with no principal.

Currently, we do not allow dynamic reservations without a principal. This test 
was added to verify that framework reserve operations without a principal will 
fail as expected.


Diffs (updated)
-

  src/tests/reservation_tests.cpp 2ea3b6e48e75f438b325211fb562db19bd3a82e0 

Diff: https://reviews.apache.org/r/42361/diff/


Testing
---

A new test, `ReservationTest.ReservationInfoNoPrincipal`, was added, and `make 
check` was used to test. The new test was also run with `--gtest_repeat=1000 
--gtest_break_on_failure=1`.


Thanks,

Greg Mann

Re: Review Request 42361: Added dynamic reservation test with no principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42361/
---

(Updated Jan. 16, 2016, 4:31 p.m.)


Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.


Changes
---

Added target version to comment.


Bugs: MESOS-4195
https://issues.apache.org/jira/browse/MESOS-4195


Repository: mesos


Description
---

Added dynamic reservation test with no principal.

Currently, we do not allow dynamic reservations without a principal. This test 
was added to verify that framework reserve operations without a principal will 
fail as expected.


Diffs (updated)
-

  src/tests/reservation_tests.cpp 2ea3b6e48e75f438b325211fb562db19bd3a82e0 

Diff: https://reviews.apache.org/r/42361/diff/


Testing
---

A new test, `ReservationTest.ReservationInfoNoPrincipal`, was added, and `make 
check` was used to test. The new test was also run with `--gtest_repeat=1000 
--gtest_break_on_failure=1`.


Thanks,

Greg Mann

Re: Review Request 42361: Added dynamic reservation test with no principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42361/
---

(Updated Jan. 15, 2016, 11:55 p.m.)


Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.


Changes
---

Removed unnecessary `Clock::settle` and `Clock::advance`.


Bugs: MESOS-4195
https://issues.apache.org/jira/browse/MESOS-4195


Repository: mesos


Description
---

Added dynamic reservation test with no principal.

Currently, we do not allow dynamic reservations without a principal. This test 
was added to verify that framework reserve operations without a principal will 
fail as expected.


Diffs (updated)
-

  src/tests/reservation_tests.cpp 2ea3b6e48e75f438b325211fb562db19bd3a82e0 

Diff: https://reviews.apache.org/r/42361/diff/


Testing
---

A new test, `ReservationTest.ReservationInfoNoPrincipal`, was added, and `make 
check` was used to test. The new test was also run with `--gtest_repeat=1000 
--gtest_break_on_failure=1`.


Thanks,

Greg Mann

Re: Review Request 42361: Added dynamic reservation test with no principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42361/
---

(Updated Jan. 15, 2016, 11:17 p.m.)


Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.


Bugs: MESOS-4195
https://issues.apache.org/jira/browse/MESOS-4195


Repository: mesos


Description
---

Added dynamic reservation test with no principal.

Currently, we do not allow dynamic reservations without a principal. This test 
was added to verify that framework reserve operations without a principal will 
fail as expected.


Diffs
-

  src/tests/reservation_tests.cpp 2ea3b6e48e75f438b325211fb562db19bd3a82e0 

Diff: https://reviews.apache.org/r/42361/diff/


Testing
---

A new test, `ReservationTest.ReservationInfoNoPrincipal`, was added, and `make 
check` was used to test. The new test was also run with `--gtest_repeat=1000 
--gtest_break_on_failure=1`.


Thanks,

Greg Mann