Re: Review Request 42441: Speed up ExamplesTest test cases.
> On Jan. 22, 2016, 1:59 p.m., Jian Qiu wrote: > > The reason I think is that the master starting from local drop the > > framework authentication message before it is fully started which cause the > > authentication timeout. I am not sure whether we can delay the start of > > framework until master has been fully started? > > haosdent huang wrote: > Because add a delay in a example looks strange and may let user confuse, > I change the authenticate timeout here. Could you please describe the reason why tests are slow in the Jira? - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42441/#review115843 --- On April 9, 2016, 8:41 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42441/ > --- > > (Updated April 9, 2016, 8:41 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Jian Qiu. > > > Bugs: MESOS-4155 > https://issues.apache.org/jira/browse/MESOS-4155 > > > Repository: mesos > > > Description > --- > > Speed up ExamplesTest test cases by decrease scheduler authenticate > timeout. > > > Diffs > - > > src/sched/constants.hpp df8a1cc83ee3986400d633b2192b6da7fbe6b626 > src/sched/flags.hpp b4ca12b667283cee1f96a4b421fcf3b06bbe59d7 > src/sched/sched.cpp 5f6f5518f0858c680dc0dffc933c0bb03bba6991 > src/tests/java_exception_test.sh fd02322096d09cee6cc22340f18681ad372867b5 > src/tests/java_framework_test.sh 8fccc699133c6db6130153c367ce01ba3931c1a2 > src/tests/no_executor_framework_test.sh > 4fa154ee52454fe3f56161abaa29e58793e627e3 > src/tests/persistent_volume_framework_test.sh > 074cdcbc4a738170e84887c1773cd7c118112d58 > src/tests/python_framework_test.sh dc3a50f4fe8d3340429996622e62f732941985a2 > src/tests/test_framework_test.sh 617ca5283bd626b535d0f8091bd1d622d175f6d8 > src/tests/test_http_framework_test.sh > 3a2b24cd5017f3535340cb8ade13b34e341cd7ce > > Diff: https://reviews.apache.org/r/42441/diff/ > > > Testing > --- > > Repeat test in CentOS 7.1 > ``` > $ sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" > --gtest_repeat=200 --gtest_break_on_failure > ``` > > > Thanks, > > haosdent huang > >
Re: Review Request 42441: Speed up ExamplesTest test cases.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42441/#review127984 --- Patch looks great! Reviews applied: [42441] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On April 9, 2016, 8:41 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42441/ > --- > > (Updated April 9, 2016, 8:41 a.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jian Qiu. > > > Bugs: MESOS-4155 > https://issues.apache.org/jira/browse/MESOS-4155 > > > Repository: mesos > > > Description > --- > > Speed up ExamplesTest test cases by decrease scheduler authenticate > timeout. > > > Diffs > - > > src/sched/constants.hpp df8a1cc83ee3986400d633b2192b6da7fbe6b626 > src/sched/flags.hpp b4ca12b667283cee1f96a4b421fcf3b06bbe59d7 > src/sched/sched.cpp 5f6f5518f0858c680dc0dffc933c0bb03bba6991 > src/tests/java_exception_test.sh fd02322096d09cee6cc22340f18681ad372867b5 > src/tests/java_framework_test.sh 8fccc699133c6db6130153c367ce01ba3931c1a2 > src/tests/no_executor_framework_test.sh > 4fa154ee52454fe3f56161abaa29e58793e627e3 > src/tests/persistent_volume_framework_test.sh > 074cdcbc4a738170e84887c1773cd7c118112d58 > src/tests/python_framework_test.sh dc3a50f4fe8d3340429996622e62f732941985a2 > src/tests/test_framework_test.sh 617ca5283bd626b535d0f8091bd1d622d175f6d8 > src/tests/test_http_framework_test.sh > 3a2b24cd5017f3535340cb8ade13b34e341cd7ce > > Diff: https://reviews.apache.org/r/42441/diff/ > > > Testing > --- > > Repeat test in CentOS 7.1 > ``` > $ sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" > --gtest_repeat=200 --gtest_break_on_failure > ``` > > > Thanks, > > haosdent huang > >
Re: Review Request 42441: Speed up ExamplesTest test cases.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42441/ --- (Updated April 9, 2016, 8:41 a.m.) Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jian Qiu. Changes --- Update according to @alexr's comments. Summary (updated) - Speed up ExamplesTest test cases. Bugs: MESOS-4155 https://issues.apache.org/jira/browse/MESOS-4155 Repository: mesos Description (updated) --- Speed up ExamplesTest test cases by decrease scheduler authenticate timeout. Diffs (updated) - src/sched/constants.hpp df8a1cc83ee3986400d633b2192b6da7fbe6b626 src/sched/flags.hpp b4ca12b667283cee1f96a4b421fcf3b06bbe59d7 src/sched/sched.cpp 5f6f5518f0858c680dc0dffc933c0bb03bba6991 src/tests/java_exception_test.sh fd02322096d09cee6cc22340f18681ad372867b5 src/tests/java_framework_test.sh 8fccc699133c6db6130153c367ce01ba3931c1a2 src/tests/no_executor_framework_test.sh 4fa154ee52454fe3f56161abaa29e58793e627e3 src/tests/persistent_volume_framework_test.sh 074cdcbc4a738170e84887c1773cd7c118112d58 src/tests/python_framework_test.sh dc3a50f4fe8d3340429996622e62f732941985a2 src/tests/test_framework_test.sh 617ca5283bd626b535d0f8091bd1d622d175f6d8 src/tests/test_http_framework_test.sh 3a2b24cd5017f3535340cb8ade13b34e341cd7ce Diff: https://reviews.apache.org/r/42441/diff/ Testing (updated) --- Repeat test in CentOS 7.1 ``` $ sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --gtest_repeat=200 --gtest_break_on_failure ``` Thanks, haosdent huang
