Re: Review Request 42473: Multiple Disk: Updated filesystem isolators to use 'DiskInfo.Source'.

2016-01-22 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42473/
---

(Updated Jan. 22, 2016, 9:29 a.m.)


Review request for mesos, Jie Yu and Michael Park.


Changes
---

Leveraged new `getPersistentVolumePath` overload.


Bugs: MESOS-4402
https://issues.apache.org/jira/browse/MESOS-4402


Repository: mesos


Description
---

Multiple Disk: Updated filesystem isolators to use 'DiskInfo.Source'.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
96c37ed7ac27074eb79e3eb5e0301b642ab653f2 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
d914587eedc9c66bc14b4088ec211b7f0eea63ea 

Diff: https://reviews.apache.org/r/42473/diff/


Testing
---


Thanks,

Joris Van Remoortere



Re: Review Request 42473: Multiple Disk: Updated filesystem isolators to use 'DiskInfo.Source'.

2016-01-22 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42473/#review115868
---

Ship it!



src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (lines 613 - 615)


This fits in one line?



src/slave/containerizer/mesos/isolators/filesystem/posix.cpp (lines 185 - 187)


Ditto. This fits in one line?


- Jie Yu


On Jan. 22, 2016, 9:29 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42473/
> ---
> 
> (Updated Jan. 22, 2016, 9:29 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Michael Park.
> 
> 
> Bugs: MESOS-4402
> https://issues.apache.org/jira/browse/MESOS-4402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Multiple Disk: Updated filesystem isolators to use 'DiskInfo.Source'.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 96c37ed7ac27074eb79e3eb5e0301b642ab653f2 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> d914587eedc9c66bc14b4088ec211b7f0eea63ea 
> 
> Diff: https://reviews.apache.org/r/42473/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>



Re: Review Request 42473: Multiple Disk: Updated filesystem isolators to use 'DiskInfo.Source'.

2016-01-20 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42473/
---

(Updated Jan. 21, 2016, 7:37 a.m.)


Review request for mesos, Jie Yu and Michael Park.


Changes
---

Support for `Mount` type.


Bugs: MESOS-4402
https://issues.apache.org/jira/browse/MESOS-4402


Repository: mesos


Description
---

Multiple Disk: Updated filesystem isolators to use 'DiskInfo.Source'.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
ace9e305c24a9841f1716c9bf40cd13b16ef0cec 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
d914587eedc9c66bc14b4088ec211b7f0eea63ea 

Diff: https://reviews.apache.org/r/42473/diff/


Testing
---


Thanks,

Joris Van Remoortere



Re: Review Request 42473: Multiple Disk: Updated filesystem isolators to use 'DiskInfo.Source'.

2016-01-20 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42473/#review115471
---

Ship it!



src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (lines 618 - 621)


Can we use CHECK here instead. I think we already validate this master.



src/slave/containerizer/mesos/isolators/filesystem/posix.cpp (lines 192 - 195)


Ditto.


- Jie Yu


On Jan. 20, 2016, 7:15 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42473/
> ---
> 
> (Updated Jan. 20, 2016, 7:15 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Michael Park.
> 
> 
> Bugs: MESOS-4402
> https://issues.apache.org/jira/browse/MESOS-4402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Multiple Disk: Updated filesystem isolators to use 'DiskInfo.Source'.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> ace9e305c24a9841f1716c9bf40cd13b16ef0cec 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> d914587eedc9c66bc14b4088ec211b7f0eea63ea 
> 
> Diff: https://reviews.apache.org/r/42473/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>



Re: Review Request 42473: Multiple Disk: Updated filesystem isolators to use 'DiskInfo.Source'.

2016-01-20 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42473/
---

(Updated Jan. 20, 2016, 7:15 p.m.)


Review request for mesos, Jie Yu and Michael Park.


Bugs: MESOS-4402
https://issues.apache.org/jira/browse/MESOS-4402


Repository: mesos


Description (updated)
---

Multiple Disk: Updated filesystem isolators to use 'DiskInfo.Source'.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
ace9e305c24a9841f1716c9bf40cd13b16ef0cec 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
d914587eedc9c66bc14b4088ec211b7f0eea63ea 

Diff: https://reviews.apache.org/r/42473/diff/


Testing
---


Thanks,

Joris Van Remoortere