Re: Review Request 42518: Disabled "drop_log_memory" flag for glog.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42518/#review116002 --- Patch looks great! Reviews applied: [42518] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 23, 2016, 3:59 a.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42518/ > --- > > (Updated Jan. 23, 2016, 3:59 a.m.) > > > Review request for mesos, Ben Mahler, Cody Maloney, and Joris Van Remoortere. > > > Bugs: MESOS-920 > https://issues.apache.org/jira/browse/MESOS-920 > > > Repository: mesos > > > Description > --- > > When this flag is set, glog makes several hundred `posix_fadvise(..., > POSIX_FADV_DONTNEED)` calls per second to advise the kernel to drop > in-memory buffers related to log contents. > > > Diffs > - > > src/logging/logging.cpp f7619b18fa4a78b20951edad892ca5c616bbed55 > > Diff: https://reviews.apache.org/r/42518/diff/ > > > Testing > --- > > Verified with the patch by running under gdb and placing a breakpoint on > posix_fadvise. The breakpoint doesn't hit anymore. > > > Thanks, > > Kapil Arya > >
Re: Review Request 42518: Disabled "drop_log_memory" flag for glog.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42518/#review116000 --- Ship it! Thanks Kapil! - Ben Mahler On Jan. 23, 2016, 3:59 a.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42518/ > --- > > (Updated Jan. 23, 2016, 3:59 a.m.) > > > Review request for mesos, Ben Mahler, Cody Maloney, and Joris Van Remoortere. > > > Bugs: MESOS-920 > https://issues.apache.org/jira/browse/MESOS-920 > > > Repository: mesos > > > Description > --- > > When this flag is set, glog makes several hundred `posix_fadvise(..., > POSIX_FADV_DONTNEED)` calls per second to advise the kernel to drop > in-memory buffers related to log contents. > > > Diffs > - > > src/logging/logging.cpp f7619b18fa4a78b20951edad892ca5c616bbed55 > > Diff: https://reviews.apache.org/r/42518/diff/ > > > Testing > --- > > Verified with the patch by running under gdb and placing a breakpoint on > posix_fadvise. The breakpoint doesn't hit anymore. > > > Thanks, > > Kapil Arya > >
Re: Review Request 42518: Disabled "drop_log_memory" flag for glog.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42518/ --- (Updated Jan. 22, 2016, 10:59 p.m.) Review request for mesos, Ben Mahler, Cody Maloney, and Joris Van Remoortere. Changes --- Update the flag only if env var is not set. Bugs: MESOS-920 https://issues.apache.org/jira/browse/MESOS-920 Repository: mesos Description --- When this flag is set, glog makes several hundred `posix_fadvise(..., POSIX_FADV_DONTNEED)` calls per second to advise the kernel to drop in-memory buffers related to log contents. Diffs (updated) - src/logging/logging.cpp f7619b18fa4a78b20951edad892ca5c616bbed55 Diff: https://reviews.apache.org/r/42518/diff/ Testing --- Verified with the patch by running under gdb and placing a breakpoint on posix_fadvise. The breakpoint doesn't hit anymore. Thanks, Kapil Arya
