Re: Review Request 42538: Supported image specified env var.

[Gilbert Song]

> On Jan. 29, 2016, 11:09 a.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 931
> > 
> >
> > s/Overwrting/Overwriting/g
> > 
> > I also wonder if this is too verbose? Should we make this VLOG(2) 
> > instead?

It looks good to me with `VLOG(1)`, because it is just one line string. We may 
want some giant error msg or string objects using `VLOG(2)`.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42538/#review116985
---


On Jan. 29, 2016, 1:27 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42538/
> ---
> 
> (Updated Jan. 29, 2016, 1:27 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4383
> https://issues.apache.org/jira/browse/MESOS-4383
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported image specified env var.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 811ab7937279c4a55da450c136f9fcb1303ea0d5 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 4b504dbb58823ce7675f1d2048dcc7a27c05663d 
> 
> Diff: https://reviews.apache.org/r/42538/diff/
> 
> 
> Testing
> ---
> 
> make check(ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 42538: Supported image specified env var.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42538/
---

(Updated Jan. 29, 2016, 1:27 p.m.)


Review request for mesos, Jie Yu and Timothy Chen.


Bugs: MESOS-4383
https://issues.apache.org/jira/browse/MESOS-4383


Repository: mesos


Description
---

Supported image specified env var.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.hpp 
811ab7937279c4a55da450c136f9fcb1303ea0d5 
  src/slave/containerizer/mesos/containerizer.cpp 
4b504dbb58823ce7675f1d2048dcc7a27c05663d 

Diff: https://reviews.apache.org/r/42538/diff/


Testing
---

make check(ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song