Re: Review Request 42590: Removed reserved() API.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/ --- (Updated 三月 11, 2016, 9:08 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 42590: Removed reserved() API.

2016-02-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/#review121220 --- Patch looks great! Reviews applied: [42590] Passed command: expo

Re: Review Request 42590: Removed reserved() API.

2016-02-29 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/ --- (Updated 二月 29, 2016, 9:11 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 42590: Removed reserved() API.

2016-02-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/#review121213 --- Bad patch! Reviews applied: [42590] Failed command: ./support/ap

Re: Review Request 42590: Removed reserved() API.

2016-02-28 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/ --- (Updated 二月 29, 2016, 7:54 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 42590: Removed reserved() API.

2016-01-22 Thread Joseph Wu
> On Jan. 21, 2016, 10:37 a.m., Joseph Wu wrote: > > include/mesos/v1/resources.hpp, line 227 > > > > > > Instead of changing this to an Option, you should default to `"*"`. > > > > Otherwise, you end up wit

Re: Review Request 42590: Removed reserved() API.

2016-01-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/#review115802 --- Patch looks great! Reviews applied: [40375, 41334, 41333, 42547, 4

Re: Review Request 42590: Removed reserved() API.

2016-01-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/ --- (Updated 一月 22, 2016, 3:37 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 42590: Removed reserved() API.

2016-01-21 Thread Guangya Liu
> On 一月 21, 2016, 6:37 p.m., Joseph Wu wrote: > > include/mesos/v1/resources.hpp, line 227 > > > > > > Instead of changing this to an Option, you should default to `"*"`. > > > > Otherwise, you end up with t

Re: Review Request 42590: Removed reserved() API.

2016-01-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/#review115640 --- include/mesos/v1/resources.hpp (line 224)

Re: Review Request 42590: Removed reserved() API.

2016-01-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/ --- (Updated 一月 21, 2016, 3:23 p.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 42590: Removed reserved() API.

2016-01-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/#review115597 --- Patch looks great! Reviews applied: [42590] Passed command: expor