Re: Review Request 42605: Fixed a NULL pointer dereference bug in Slave.

2016-01-22 Thread Timothy Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42605/#review115895
---

Ship it!


Ship It!

- Timothy Chen


On Jan. 22, 2016, 3:57 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42605/
> ---
> 
> (Updated Jan. 22, 2016, 3:57 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4449
> https://issues.apache.org/jira/browse/MESOS-4449
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This fixes a `NULL` pointer dereference erroneously added as part of 
> introducing an output operator for the `Executor` struct in 
> https://reviews.apache.org/r/39569.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 759c8d5b1bfb5ad723aa423e1487998ed62bbc3a 
> 
> Diff: https://reviews.apache.org/r/42605/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 42605: Fixed a NULL pointer dereference bug in Slave.

2016-01-22 Thread Shuai Lin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42605/#review115852
---

Ship it!


Ship It!

- Shuai Lin


On Jan. 22, 2016, 3:57 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42605/
> ---
> 
> (Updated Jan. 22, 2016, 3:57 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4449
> https://issues.apache.org/jira/browse/MESOS-4449
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This fixes a `NULL` pointer dereference erroneously added as part of 
> introducing an output operator for the `Executor` struct in 
> https://reviews.apache.org/r/39569.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 759c8d5b1bfb5ad723aa423e1487998ed62bbc3a 
> 
> Diff: https://reviews.apache.org/r/42605/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 42605: Fixed a NULL pointer dereference bug in Slave.

2016-01-21 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42605/#review115751
---


Patch looks great!

Reviews applied: [42605]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 21, 2016, 6:11 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42605/
> ---
> 
> (Updated Jan. 21, 2016, 6:11 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4449
> https://issues.apache.org/jira/browse/MESOS-4449
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This fixes a `NULL` pointer dereference erroneously added as part of 
> introducing an output operator for the `Executor` struct in 
> https://reviews.apache.org/r/39569.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp e23c3295c8ebed580751a5aabaf26e1773c54859 
> 
> Diff: https://reviews.apache.org/r/42605/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>