Re: Review Request 42618: Modified the `cgroups/net_cls` isolator to use the `NetClsHandleMgr`.

2016-02-01 Thread Jie Yu
> On Feb. 1, 2016, 9:40 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, lines 454-455 > > > > > > In fact, i think we should add a helper in src/linux/cgroup.hpp (like > > we

Re: Review Request 42618: Modified the `cgroups/net_cls` isolator to use the `NetClsHandleMgr`.

2016-02-01 Thread Avinash sridharan
> On Feb. 1, 2016, 9:40 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, lines 454-455 > > > > > > In fact, i think we should add a helper in src/linux/cgroup.hpp (like > > we

Re: Review Request 42618: Modified the `cgroups/net_cls` isolator to use the `NetClsHandleMgr`.

2016-02-01 Thread Avinash sridharan
> On Feb. 1, 2016, 8:14 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, lines 499-503 > > > > > > You should do this after the cgroup has been destroyed. Makes sense. Planning

Re: Review Request 42618: Modified the `cgroups/net_cls` isolator to use the `NetClsHandleMgr`.

2016-01-25 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/ --- (Updated Jan. 26, 2016, 6:35 a.m.) Review request for mesos and Jie Yu.