Re: Review Request 42696: Speed up FetcherCacheTest.Local* test by reduce loop.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/#review119427 --- Ship it! Now without the checkpointing-related code which went into a separate review, let's ship it! - Bernd Mathiske On Feb. 16, 2016, 6:10 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42696/ > --- > > (Updated Feb. 16, 2016, 6:10 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd > Mathiske. > > > Bugs: MESOS-4486 > https://issues.apache.org/jira/browse/MESOS-4486 > > > Repository: mesos > > > Description > --- > > Speed up FetcherCacheTest.Local* test by reduce loop. > > > Diffs > - > > src/tests/fetcher_cache_tests.cpp fc89be46bc4cca81f6f3f5072539d3dae26f7c8f > > Diff: https://reviews.apache.org/r/42696/diff/ > > > Testing > --- > > Before > ``` > [ OK ] FetcherCacheTest.LocalUncached (2580 ms) > [ OK ] FetcherCacheTest.LocalCached (2516 ms) > [ OK ] FetcherCacheTest.LocalUncachedExtract (2519 ms) > [ OK ] FetcherCacheTest.LocalCachedExtract (2594 ms) > ``` > > After > ``` > [ OK ] FetcherCacheTest.LocalUncached (977 ms) > [ OK ] FetcherCacheTest.LocalCached (1731 ms) > [ OK ] FetcherCacheTest.LocalUncachedExtract (975 ms) > [ OK ] FetcherCacheTest.LocalCachedExtract (1713 ms) > ``` > > > Thanks, > > haosdent huang > >
Re: Review Request 42696: Speed up FetcherCacheTest.Local* test by reduce loop.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/ --- (Updated Feb. 17, 2016, 2:10 a.m.) Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd Mathiske. Changes --- Rebase Bugs: MESOS-4486 https://issues.apache.org/jira/browse/MESOS-4486 Repository: mesos Description --- Speed up FetcherCacheTest.Local* test by reduce loop. Diffs (updated) - src/tests/fetcher_cache_tests.cpp fc89be46bc4cca81f6f3f5072539d3dae26f7c8f Diff: https://reviews.apache.org/r/42696/diff/ Testing --- Before ``` [ OK ] FetcherCacheTest.LocalUncached (2580 ms) [ OK ] FetcherCacheTest.LocalCached (2516 ms) [ OK ] FetcherCacheTest.LocalUncachedExtract (2519 ms) [ OK ] FetcherCacheTest.LocalCachedExtract (2594 ms) ``` After ``` [ OK ] FetcherCacheTest.LocalUncached (977 ms) [ OK ] FetcherCacheTest.LocalCached (1731 ms) [ OK ] FetcherCacheTest.LocalUncachedExtract (975 ms) [ OK ] FetcherCacheTest.LocalCachedExtract (1713 ms) ``` Thanks, haosdent huang
Re: Review Request 42696: Speed up FetcherCacheTest.Local* test by reduce loop.
> On Feb. 16, 2016, 11:02 a.m., Alexander Rukletsov wrote: > > Could you please explain in description why disabling checkpointing speeds > > up the test and why it is ok to disable it for these tests? > > haosdent huang wrote: > Sure! > > Bernd Mathiske wrote: > Not writing to disk costs less time. > > If a test does not attempt recovery, then whatever would be checkpointed > never gets used. > > Only one test attempts/tests recovery so far. In this test we do apply > checkpointing. So it does get tested, but we don't need to test the writing > part of it in every other test. > > Alexander Rukletsov wrote: > I'm a bit confused about what contributes most here. Is it checkpointing > or rather the other change? It's a bit strange to me that checkpointing > significantly influences the test duration. If so, I would like to understand > why, of not, them maybe we can pull it out of the change to avoid > distraction. Also It's not clear at the first glance why it's ok to reduce > some loops in the tests and why they were there in the first place. > > it would be great to have one fix per patch with explanation why it helps > and how much. > > haosdent huang wrote: > >it would be great to have one fix per patch with explanation why it > helps and how much. > > Sure. My test machine is use SATA disk. And becsue we write to disk when > status_update, would cause >100 ms delay when I testing. I agree with you. > Let me split up them and explain why it helps and how much. @alex-mesos @bernd-mesos @bbannier Thank you very much for your great review and comments. I finish updated this round. Could you help review them again if you have time? Thank you very much. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/#review119294 --- On Feb. 16, 2016, 5:55 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42696/ > --- > > (Updated Feb. 16, 2016, 5:55 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd > Mathiske. > > > Bugs: MESOS-4486 > https://issues.apache.org/jira/browse/MESOS-4486 > > > Repository: mesos > > > Description > --- > > Speed up FetcherCacheTest.Local* test by reduce loop. > > > Diffs > - > > src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf > > Diff: https://reviews.apache.org/r/42696/diff/ > > > Testing > --- > > Before > ``` > [ OK ] FetcherCacheTest.LocalUncached (2580 ms) > [ OK ] FetcherCacheTest.LocalCached (2516 ms) > [ OK ] FetcherCacheTest.LocalUncachedExtract (2519 ms) > [ OK ] FetcherCacheTest.LocalCachedExtract (2594 ms) > ``` > > After > ``` > [ OK ] FetcherCacheTest.LocalUncached (977 ms) > [ OK ] FetcherCacheTest.LocalCached (1731 ms) > [ OK ] FetcherCacheTest.LocalUncachedExtract (975 ms) > [ OK ] FetcherCacheTest.LocalCachedExtract (1713 ms) > ``` > > > Thanks, > > haosdent huang > >
Re: Review Request 42696: Speed up FetcherCacheTest.Local* test by reduce loop.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/ --- (Updated Feb. 16, 2016, 5:55 p.m.) Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd Mathiske. Changes --- Rebase Summary (updated) - Speed up FetcherCacheTest.Local* test by reduce loop. Bugs: MESOS-4486 https://issues.apache.org/jira/browse/MESOS-4486 Repository: mesos Description (updated) --- Speed up FetcherCacheTest.Local* test by reduce loop. Diffs (updated) - src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf Diff: https://reviews.apache.org/r/42696/diff/ Testing (updated) --- Before ``` [ OK ] FetcherCacheTest.LocalUncached (2580 ms) [ OK ] FetcherCacheTest.LocalCached (2516 ms) [ OK ] FetcherCacheTest.LocalUncachedExtract (2519 ms) [ OK ] FetcherCacheTest.LocalCachedExtract (2594 ms) ``` After ``` [ OK ] FetcherCacheTest.LocalUncached (977 ms) [ OK ] FetcherCacheTest.LocalCached (1731 ms) [ OK ] FetcherCacheTest.LocalUncachedExtract (975 ms) [ OK ] FetcherCacheTest.LocalCachedExtract (1713 ms) ``` Thanks, haosdent huang
