Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-16 Thread haosdent huang
> On Feb. 16, 2016, 11:02 a.m., Alexander Rukletsov wrote: > > Could you please explain in description why disabling checkpointing speeds > > up the test and why it is ok to disable it for these tests? > > haosdent huang wrote: > Sure! > > Bernd Mathiske wrote: > Not writing to disk co

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-16 Thread Alexander Rukletsov
> On Feb. 16, 2016, 11:02 a.m., Alexander Rukletsov wrote: > > Could you please explain in description why disabling checkpointing speeds > > up the test and why it is ok to disable it for these tests? > > haosdent huang wrote: > Sure! > > Bernd Mathiske wrote: > Not writing to disk co

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-16 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/#review119302 --- Ship it! - Benjamin Bannier On Feb. 16, 2016, 12:39 p.m., hao

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-16 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/ --- (Updated Feb. 16, 2016, 11:39 a.m.) Review request for mesos and Bernd Mathiske

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-16 Thread Bernd Mathiske
> On Feb. 16, 2016, 3:02 a.m., Alexander Rukletsov wrote: > > Could you please explain in description why disabling checkpointing speeds > > up the test and why it is ok to disable it for these tests? > > haosdent huang wrote: > Sure! Not writing to disk costs less time. If a test does no

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-16 Thread haosdent huang
> On Feb. 16, 2016, 11:02 a.m., Alexander Rukletsov wrote: > > Could you please explain in description why disabling checkpointing speeds > > up the test and why it is ok to disable it for these tests? Sure! - haosdent --- This is an a

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-16 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/#review119291 --- src/tests/fetcher_cache_tests.cpp (line 115)

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/#review119294 --- Could you please explain in description why disabling checkpointin

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-16 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/#review119290 --- Ship it! Ship It! - Bernd Mathiske On Feb. 9, 2016, 4:48 p.m

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/ --- (Updated Feb. 10, 2016, 12:48 a.m.) Review request for mesos and Bernd Mathiske

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/ --- (Updated Feb. 9, 2016, 6:17 p.m.) Review request for mesos and Bernd Mathiske.

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-01-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/#review116547 --- Patch looks great! Reviews applied: [42696] Passed command: expo

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-01-26 Thread haosdent huang
> On Jan. 26, 2016, 9:18 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 196 > > > > > > Good idea, but then we need to set checkpointing to true for the > > recovery test below. @bernd, tha

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-01-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/ --- (Updated Jan. 27, 2016, 3:04 a.m.) Review request for mesos and Bernd Mathiske.

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-01-26 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/#review116330 --- src/tests/fetcher_cache_tests.cpp (line 196)

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-01-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/#review116022 --- Patch looks great! Reviews applied: [42696] Passed command: expo