Re: Review Request 42735: Make commit-msg hook portable.

2016-01-26 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42735/ --- (Updated Jan. 26, 2016, 8:40 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 42735: Make commit-msg hook portable.

2016-01-26 Thread David Forsythe
> On Jan. 25, 2016, 9:52 p.m., Ian Downes wrote: > > Can you please fix the other bash Linux-isms in this patch while you're at > > it? > > ``` > > [1350][idownes:mesos]$ git grep "!\/bin\/bash" > > support/atexit.sh:#!/bin/bash > > support/coverage.sh:#!/bin/bash > >

Re: Review Request 42735: Make commit-msg hook portable.

2016-01-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42735/#review116174 --- Patch looks great! Reviews applied: [42735] Passed command:

Re: Review Request 42735: Make commit-msg hook portable.

2016-01-25 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42735/#review116182 --- Can you please fix the other bash Linux-isms in this patch while