Re: Review Request 42735: Make commit-msg hook portable.

2016-01-26 Thread David Forsythe

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42735/
---

(Updated Jan. 26, 2016, 8:40 a.m.)


Review request for mesos, Artem Harutyunyan and Ian Downes.


Changes
---

Update other bash scripts.


Bugs: MESOS-4502
https://issues.apache.org/jira/browse/MESOS-4502


Repository: mesos


Description
---

Make commit-msg hook portable.


Diffs (updated)
-

  support/atexit.sh 90696a2d426ff013d1aaec7800c6dc880bc2a00c 
  support/coverage.sh df81f9a45d043d506f47e9d6fac6893bf044144a 
  support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 
  support/hooks/commit-msg d173dfdf380b08a9b349589dfd33c53b3cdccc60 
  support/release.sh 633bbace091bddd582b9fcef5d35b331a0f169f0 
  support/tag.sh 9d37c81a13cb0c281f4a53884c6c55e09c341d85 
  support/vote.sh 218a38512d4dc8e160d975a99c577e4411879eee 

Diff: https://reviews.apache.org/r/42735/diff/


Testing
---


Thanks,

David Forsythe



Re: Review Request 42735: Make commit-msg hook portable.

2016-01-26 Thread David Forsythe


> On Jan. 25, 2016, 9:52 p.m., Ian Downes wrote:
> > Can you please fix the other bash Linux-isms in this patch while you're at 
> > it?
> > ```
> > [1350][idownes:mesos]$ git grep "!\/bin\/bash"
> > support/atexit.sh:#!/bin/bash
> > support/coverage.sh:#!/bin/bash
> > support/docker_build.sh:#!/bin/bash
> > support/hooks/commit-msg:#!/bin/bash
> > support/release.sh:#!/bin/bash
> > support/tag.sh:#!/bin/bash
> > support/vote.sh:#!/bin/bash
> > ```

Sure thing.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42735/#review116182
---


On Jan. 25, 2016, 8:07 p.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42735/
> ---
> 
> (Updated Jan. 25, 2016, 8:07 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Ian Downes.
> 
> 
> Bugs: MESOS-4502
> https://issues.apache.org/jira/browse/MESOS-4502
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make commit-msg hook portable.
> 
> 
> Diffs
> -
> 
>   support/hooks/commit-msg d173dfdf380b08a9b349589dfd33c53b3cdccc60 
> 
> Diff: https://reviews.apache.org/r/42735/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Forsythe
> 
>



Re: Review Request 42735: Make commit-msg hook portable.

2016-01-25 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42735/#review116174
---



Patch looks great!

Reviews applied: [42735]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 25, 2016, 8:07 p.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42735/
> ---
> 
> (Updated Jan. 25, 2016, 8:07 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Ian Downes.
> 
> 
> Bugs: MESOS-4502
> https://issues.apache.org/jira/browse/MESOS-4502
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make commit-msg hook portable.
> 
> 
> Diffs
> -
> 
>   support/hooks/commit-msg d173dfdf380b08a9b349589dfd33c53b3cdccc60 
> 
> Diff: https://reviews.apache.org/r/42735/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Forsythe
> 
>



Re: Review Request 42735: Make commit-msg hook portable.

2016-01-25 Thread Ian Downes

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42735/#review116182
---



Can you please fix the other bash Linux-isms in this patch while you're at it?
```
[1350][idownes:mesos]$ git grep "!\/bin\/bash"
support/atexit.sh:#!/bin/bash
support/coverage.sh:#!/bin/bash
support/docker_build.sh:#!/bin/bash
support/hooks/commit-msg:#!/bin/bash
support/release.sh:#!/bin/bash
support/tag.sh:#!/bin/bash
support/vote.sh:#!/bin/bash
```

- Ian Downes


On Jan. 25, 2016, 12:07 p.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42735/
> ---
> 
> (Updated Jan. 25, 2016, 12:07 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Ian Downes.
> 
> 
> Bugs: MESOS-4502
> https://issues.apache.org/jira/browse/MESOS-4502
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make commit-msg hook portable.
> 
> 
> Diffs
> -
> 
>   support/hooks/commit-msg d173dfdf380b08a9b349589dfd33c53b3cdccc60 
> 
> Diff: https://reviews.apache.org/r/42735/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Forsythe
> 
>