Re: Review Request 42751: Tweaked some resource test cases.

2016-02-05 Thread Michael Park
> On Feb. 5, 2016, 2:33 a.m., Guangya Liu wrote: > > src/tests/resources_tests.cpp, lines 327-328 > > > > > > Just a question, do we have some guidelines for when to use `ASSERT_EQ` > > and when to use `EXPECT_EQ`

Re: Review Request 42751: Tweaked some resource test cases.

2016-02-05 Thread Guangya Liu
> On 二月 5, 2016, 2:33 a.m., Guangya Liu wrote: > > src/tests/resources_tests.cpp, lines 327-328 > > > > > > Just a question, do we have some guidelines for when to use `ASSERT_EQ` > > and when to use `EXPECT_EQ` ?

Re: Review Request 42751: Tweaked some resource test cases.

2016-02-04 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42751/ --- (Updated Feb. 5, 2016, 2:19 a.m.) Review request for mesos and Michael Park.

Re: Review Request 42751: Tweaked some resource test cases.

2016-02-04 Thread Neil Conway
> On Feb. 3, 2016, 10:45 p.m., Michael Park wrote: > > src/tests/resources_tests.cpp, line 957 > > > > > > We used to have a `Resources::size()` function which essentially did > > this, but intentionally removed it

Re: Review Request 42751: Tweaked some resource test cases.

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42751/#review117946 --- src/tests/resources_tests.cpp (lines 326 - 327)

Re: Review Request 42751: Tweaked some resource test cases.

2016-02-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42751/ --- (Updated Feb. 3, 2016, 11:04 p.m.) Review request for mesos and Michael Park.

Re: Review Request 42751: Tweaked some resource test cases.

2016-02-03 Thread Michael Park
> On Feb. 3, 2016, 10:45 p.m., Michael Park wrote: > > src/tests/resources_tests.cpp, line 957 > > > > > > We used to have a `Resources::size()` function which essentially did > > this, but intentionally removed it

Re: Review Request 42751: Tweaked some resource test cases.

2016-02-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42751/#review117743 --- src/tests/resources_tests.cpp (line 185)

Re: Review Request 42751: Tweaked some resource test cases.

2016-02-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42751/#review117698 --- Fix it, then Ship it! src/tests/resources_tests.cpp (line

Re: Review Request 42751: Tweaked some resource test cases.

2016-02-03 Thread Neil Conway
> On Feb. 3, 2016, 10:45 p.m., Michael Park wrote: > > src/tests/resources_tests.cpp, line 957 > > > > > > We used to have a `Resources::size()` function which essentially did > > this, but intentionally removed it

Re: Review Request 42751: Tweaked some resource test cases.

2016-02-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42751/ --- (Updated Feb. 3, 2016, 5:51 p.m.) Review request for mesos and Michael Park.

Re: Review Request 42751: Tweaked some resource test cases.

2016-02-03 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42751/#review117635 --- Fix it, then Ship it! src/tests/resources_tests.cpp (line

Re: Review Request 42751: Tweaked some resource test cases.

2016-02-03 Thread Neil Conway
> On Feb. 3, 2016, 5:34 p.m., Joerg Schad wrote: > > src/tests/resources_tests.cpp, line 957 > > > > > > I must say this pattern (distance(begin,end)) just to get the item > > count looks unintuitive here. > >

Re: Review Request 42751: Tweaked some resource test cases.

2016-01-26 Thread Neil Conway
> On Jan. 26, 2016, 6:37 a.m., Guangya Liu wrote: > > src/tests/resources_tests.cpp, line 1603 > > > > > > Why do you update here? The goal of this test is to validate that two resources with different

Re: Review Request 42751: Tweaked some resource test cases.

2016-01-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42751/#review116289 --- src/tests/resources_tests.cpp (line 1603)

Re: Review Request 42751: Tweaked some resource test cases.

2016-01-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42751/ --- (Updated Jan. 25, 2016, 10:59 p.m.) Review request for mesos and Michael Park.