Re: Review Request 42757: Split os::memory() out into platform specific files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42757/#review118301 --- Ship it! Ship It! - Ian Downes On Feb. 5, 2016, 9:35 a.m., David Forsythe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42757/ > --- > > (Updated Feb. 5, 2016, 9:35 a.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-4504 > https://issues.apache.org/jira/browse/MESOS-4504 > > > Repository: mesos > > > Description > --- > > Split os::memory() out into platform specific files. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp > 10346dea8d658ea0a9b658a1d72eee8cc3056da8 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp > f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp > cc9bfe8942db7e62f5d415fc500b78adf2ac9759 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sunos.hpp > 0e897ea15d6b3ed76a8a264726db70980bb9517a > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > b47187870d6d8d21425253dac481e28102e8dcc9 > > Diff: https://reviews.apache.org/r/42757/diff/ > > > Testing > --- > > gmake check on FreeBSD and Ubuntu. > > > Thanks, > > David Forsythe > >
Re: Review Request 42757: Split os::memory() out into platform specific files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42757/#review118056 --- Patch looks great! Reviews applied: [42735, 42757] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Feb. 5, 2016, 5:35 p.m., David Forsythe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42757/ > --- > > (Updated Feb. 5, 2016, 5:35 p.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-4504 > https://issues.apache.org/jira/browse/MESOS-4504 > > > Repository: mesos > > > Description > --- > > Split os::memory() out into platform specific files. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp > 10346dea8d658ea0a9b658a1d72eee8cc3056da8 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp > f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp > cc9bfe8942db7e62f5d415fc500b78adf2ac9759 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sunos.hpp > 0e897ea15d6b3ed76a8a264726db70980bb9517a > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > b47187870d6d8d21425253dac481e28102e8dcc9 > > Diff: https://reviews.apache.org/r/42757/diff/ > > > Testing > --- > > gmake check on FreeBSD and Ubuntu. > > > Thanks, > > David Forsythe > >
Re: Review Request 42757: Split os::memory() out into platform specific files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42757/ --- (Updated Feb. 5, 2016, 5:35 p.m.) Review request for mesos and Ian Downes. Bugs: MESOS-4504 https://issues.apache.org/jira/browse/MESOS-4504 Repository: mesos Description --- Split os::memory() out into platform specific files. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 10346dea8d658ea0a9b658a1d72eee8cc3056da8 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp cc9bfe8942db7e62f5d415fc500b78adf2ac9759 3rdparty/libprocess/3rdparty/stout/include/stout/os/sunos.hpp 0e897ea15d6b3ed76a8a264726db70980bb9517a 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp b47187870d6d8d21425253dac481e28102e8dcc9 Diff: https://reviews.apache.org/r/42757/diff/ Testing --- gmake check on FreeBSD and Ubuntu. Thanks, David Forsythe
Re: Review Request 42757: Split os::memory() out into platform specific files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42757/#review116260 --- Patch looks great! Reviews applied: [42735, 42757] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 25, 2016, 11:11 p.m., David Forsythe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42757/ > --- > > (Updated Jan. 25, 2016, 11:11 p.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-4504 > https://issues.apache.org/jira/browse/MESOS-4504 > > > Repository: mesos > > > Description > --- > > Split os::memory() out into platform specific files. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp > 10346dea8d658ea0a9b658a1d72eee8cc3056da8 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp > f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp > cc9bfe8942db7e62f5d415fc500b78adf2ac9759 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sunos.hpp > 0e897ea15d6b3ed76a8a264726db70980bb9517a > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > 74af0077a39ef4cfa636b0b9e0c6b93eabc04bc8 > > Diff: https://reviews.apache.org/r/42757/diff/ > > > Testing > --- > > gmake check on FreeBSD and Ubuntu. > > > Thanks, > > David Forsythe > >