Re: Review Request 42761: Resource Math: Substituted DeleteSubrange with Swap + RemoveLast.

2016-01-25 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42761/#review116277
---


Ship it!




Ship It!

- Neil Conway


On Jan. 26, 2016, 5:38 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42761/
> ---
> 
> (Updated Jan. 26, 2016, 5:38 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This improves 'operator-=' performance for Resources.
> 
> 
> Diffs
> -
> 
>   src/common/resources.cpp 0fcf86014ab5c9908a1cdb3a57b7c5e70acd7737 
>   src/v1/resources.cpp 126e5a2f567d2e281da3f99bc485f7960567eee5 
> 
> Diff: https://reviews.apache.org/r/42761/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 42761: Resource Math: Substituted DeleteSubrange with Swap + RemoveLast.

2016-01-25 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42761/
---

(Updated Jan. 26, 2016, 5:38 a.m.)


Review request for mesos and Michael Park.


Changes
---

Added comment.
Updated v1.


Repository: mesos


Description
---

This improves 'operator-=' performance for Resources.


Diffs (updated)
-

  src/common/resources.cpp 0fcf86014ab5c9908a1cdb3a57b7c5e70acd7737 
  src/v1/resources.cpp 126e5a2f567d2e281da3f99bc485f7960567eee5 

Diff: https://reviews.apache.org/r/42761/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 42761: Resource Math: Substituted DeleteSubrange with Swap + RemoveLast.

2016-01-25 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42761/#review116229
---



This should also update `src/v1/resources.cpp`.


src/common/resources.cpp (line 1410)


Merits an explanatory comment, I think. Specifically: (a) rearranging the 
order of the elements of a `Resources` does not change its observed behavior 
(... I assume this is true :) ) (b) removing an element from the middle of a 
`RepeatedPtrField` requires moving the suffix of the vector down by one element.


- Neil Conway


On Jan. 26, 2016, 12:10 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42761/
> ---
> 
> (Updated Jan. 26, 2016, 12:10 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This improves 'operator-=' performance for Resources.
> 
> 
> Diffs
> -
> 
>   src/common/resources.cpp 0fcf86014ab5c9908a1cdb3a57b7c5e70acd7737 
> 
> Diff: https://reviews.apache.org/r/42761/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>