Re: Review Request 42781: Added the --cgroups_net_cls_major_handles flag to the slave.
> On Jan. 31, 2016, 8:15 p.m., Neil Conway wrote: > > Should update configuration.md. Thanks for pointing this out Neil. Will create a JIRA on ASF and track it as part of the net_cls EPIC (MESOS-4343). - Avinash --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42781/#review117152 --- On Jan. 31, 2016, 8:10 p.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42781/ > --- > > (Updated Jan. 31, 2016, 8:10 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4344 > https://issues.apache.org/jira/browse/MESOS-4344 > > > Repository: mesos > > > Description > --- > > The flag takes a uint16_t value that allows operators to specify a major > handle > to be used with net_cls cgroup. The default value of this flag is > CGROUPS_NETCLS_MAJOR_HANDLE = 0x0011. > > > Diffs > - > > src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 > src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp > b4bc52114389d1c1efce2830f4292bd89bb0de7c > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp > ddc1bf0939e5e8995e6f34fe7b8509b51704f63e > src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 > src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b > > Diff: https://reviews.apache.org/r/42781/diff/ > > > Testing > --- > > Tested the flag by launching a mesos agent and checking that the slave takes > the `--cgroups_net_cls_major_handles` flag. > > > Thanks, > > Avinash sridharan > >
Re: Review Request 42781: Added the --cgroups_net_cls_major_handles flag to the slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42781/#review117152 --- Should update configuration.md. - Neil Conway On Jan. 31, 2016, 8:10 p.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42781/ > --- > > (Updated Jan. 31, 2016, 8:10 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4344 > https://issues.apache.org/jira/browse/MESOS-4344 > > > Repository: mesos > > > Description > --- > > The flag takes a uint16_t value that allows operators to specify a major > handle > to be used with net_cls cgroup. The default value of this flag is > CGROUPS_NETCLS_MAJOR_HANDLE = 0x0011. > > > Diffs > - > > src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 > src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp > b4bc52114389d1c1efce2830f4292bd89bb0de7c > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp > ddc1bf0939e5e8995e6f34fe7b8509b51704f63e > src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 > src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b > > Diff: https://reviews.apache.org/r/42781/diff/ > > > Testing > --- > > Tested the flag by launching a mesos agent and checking that the slave takes > the `--cgroups_net_cls_major_handles` flag. > > > Thanks, > > Avinash sridharan > >
Re: Review Request 42781: Added the --cgroups_net_cls_major_handles flag to the slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42781/ --- (Updated Jan. 31, 2016, 8:10 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-4344 https://issues.apache.org/jira/browse/MESOS-4344 Repository: mesos Description --- The flag takes a uint16_t value that allows operators to specify a major handle to be used with net_cls cgroup. The default value of this flag is CGROUPS_NETCLS_MAJOR_HANDLE = 0x0011. Diffs - src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b Diff: https://reviews.apache.org/r/42781/diff/ Testing --- Tested the flag by launching a mesos agent and checking that the slave takes the `--cgroups_net_cls_major_handles` flag. Thanks, Avinash sridharan
Re: Review Request 42781: Added the --cgroups_net_cls_major_handles flag to the slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42781/ --- (Updated Jan. 31, 2016, 8:08 p.m.) Review request for mesos and Jie Yu. Summary (updated) - Added the --cgroups_net_cls_major_handles flag to the slave. Bugs: MESOS-4344 https://issues.apache.org/jira/browse/MESOS-4344 Repository: mesos Description (updated) --- The flag takes a uint16_t value that allows operators to specify a major handle to be used with net_cls cgroup. The default value of this flag is CGROUPS_NETCLS_MAJOR_HANDLE = 0x0011. Diffs (updated) - src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b Diff: https://reviews.apache.org/r/42781/diff/ Testing (updated) --- Tested the flag by launching a mesos agent and checking that the slave takes the `--cgroups_net_cls_major_handles` flag. Thanks, Avinash sridharan
