Re: Review Request 42782: Added a unit-test to test net_cls primary handles set from command line.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/
---

(Updated Feb. 8, 2016, 7:13 p.m.)


Review request for mesos and Jie Yu.


Summary (updated)
-

Added a unit-test to test net_cls primary handles set from command line.


Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344


Repository: mesos


Description (updated)
---

Added a unit-test to test net_cls primary handles set from command line.


Diffs (updated)
-

  src/tests/containerizer/isolator_tests.cpp 
84fe4fb61ac032e68d2ab22e85f6b41481c04644 

Diff: https://reviews.apache.org/r/42782/diff/


Testing
---

make and make check.


Thanks,

Avinash sridharan

Re: Review Request 42782: Added a unit-test to test net_cls primary handles set from command line.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/#review118292
---


Ship it!




Ship It!

- Jie Yu


On Feb. 8, 2016, 7:13 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42782/
> ---
> 
> (Updated Feb. 8, 2016, 7:13 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4344
> https://issues.apache.org/jira/browse/MESOS-4344
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a unit-test to test net_cls primary handles set from command line.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 84fe4fb61ac032e68d2ab22e85f6b41481c04644 
> 
> Diff: https://reviews.apache.org/r/42782/diff/
> 
> 
> Testing
> ---
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42782: Added a unit-test to test net_cls primary handles set from command line.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/#review118291
---




src/tests/containerizer/isolator_tests.cpp (line 1000)


I would use EXPECT_NE(0, classid.get() & 0x);


- Jie Yu


On Feb. 8, 2016, 7:13 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42782/
> ---
> 
> (Updated Feb. 8, 2016, 7:13 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4344
> https://issues.apache.org/jira/browse/MESOS-4344
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a unit-test to test net_cls primary handles set from command line.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 84fe4fb61ac032e68d2ab22e85f6b41481c04644 
> 
> Diff: https://reviews.apache.org/r/42782/diff/
> 
> 
> Testing
> ---
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>