Re: Review Request 42832: Added a status method to the Isolator interface.

2016-01-29 Thread Kapil Arya

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42832/#review116960
---


Ship it!




Can you also add a test to the test suite?

- Kapil Arya


On Jan. 28, 2016, 12:57 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42832/
> ---
> 
> (Updated Jan. 28, 2016, 12:57 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Kapil Arya.
> 
> 
> Bugs: MESOS-4520
> https://issues.apache.org/jira/browse/MESOS-4520
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a status method to the Isolator interface. This method can be used to 
> query the run-time state of isolator specific properties associated with a 
> container.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/isolator.hpp 2ea1fb77b4bbe811466fac18fdf7cd48d482bc75 
>   src/slave/containerizer/mesos/isolator.hpp 
> b3babd09c9dc70d6ca3dac1964eda321cb0f8be9 
>   src/slave/containerizer/mesos/isolator.cpp 
> 6d6863814fde5601bd311f6dc0816f7f1e446537 
> 
> Diff: https://reviews.apache.org/r/42832/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>



Re: Review Request 42832: Added a status method to the Isolator interface.

2016-01-28 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42832/#review116804
---


Ship it!




Ship It!

- Jie Yu


On Jan. 28, 2016, 5:57 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42832/
> ---
> 
> (Updated Jan. 28, 2016, 5:57 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Kapil Arya.
> 
> 
> Bugs: MESOS-4520
> https://issues.apache.org/jira/browse/MESOS-4520
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a status method to the Isolator interface. This method can be used to 
> query the run-time state of isolator specific properties associated with a 
> container.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/isolator.hpp 2ea1fb77b4bbe811466fac18fdf7cd48d482bc75 
>   src/slave/containerizer/mesos/isolator.hpp 
> b3babd09c9dc70d6ca3dac1964eda321cb0f8be9 
>   src/slave/containerizer/mesos/isolator.cpp 
> 6d6863814fde5601bd311f6dc0816f7f1e446537 
> 
> Diff: https://reviews.apache.org/r/42832/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>



Re: Review Request 42832: Added a status method to the Isolator interface.

2016-01-28 Thread Avinash sridharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42832/
---

(Updated Jan. 28, 2016, 5:57 p.m.)


Review request for mesos, Jie Yu and Kapil Arya.


Bugs: MESOS-4520
https://issues.apache.org/jira/browse/MESOS-4520


Repository: mesos


Description
---

Added a status method to the Isolator interface. This method can be used to 
query the run-time state of isolator specific properties associated with a 
container.


Diffs (updated)
-

  include/mesos/slave/isolator.hpp 2ea1fb77b4bbe811466fac18fdf7cd48d482bc75 
  src/slave/containerizer/mesos/isolator.hpp 
b3babd09c9dc70d6ca3dac1964eda321cb0f8be9 
  src/slave/containerizer/mesos/isolator.cpp 
6d6863814fde5601bd311f6dc0816f7f1e446537 

Diff: https://reviews.apache.org/r/42832/diff/


Testing
---

make


Thanks,

Avinash sridharan