Re: Review Request 42837: Ignored MOUNT type disk for disk quota enforcement.

2016-01-26 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42837/#review116525
---



Patch looks great!

Reviews applied: [42837]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 27, 2016, 1:23 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42837/
> ---
> 
> (Updated Jan. 27, 2016, 1:23 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4506
> https://issues.apache.org/jira/browse/MESOS-4506
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ignored MOUNT type disk for disk quota enforcement.
> 
> For MOUNT type disk, the quota should be enforced by the underlying fs 
> isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> 5ed93534330567bbac965faf53feb105045ef390 
> 
> Diff: https://reviews.apache.org/r/42837/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Re: Review Request 42837: Ignored MOUNT type disk for disk quota enforcement.

2016-01-26 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42837/#review116510
---


Ship it!




Ship It!

- Joris Van Remoortere


On Jan. 27, 2016, 1:23 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42837/
> ---
> 
> (Updated Jan. 27, 2016, 1:23 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4506
> https://issues.apache.org/jira/browse/MESOS-4506
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ignored MOUNT type disk for disk quota enforcement.
> 
> For MOUNT type disk, the quota should be enforced by the underlying fs 
> isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> 5ed93534330567bbac965faf53feb105045ef390 
> 
> Diff: https://reviews.apache.org/r/42837/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>