Re: Review Request 42968: Fixed broken build due to signed comparison warning with GCC 5.3.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42968/#review116979 --- Ship it! Ship It! - Jie Yu On Jan. 29, 2016, 6:32 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42968/ > --- > > (Updated Jan. 29, 2016, 6:32 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-4555 > https://issues.apache.org/jira/browse/MESOS-4555 > > > Repository: mesos > > > Description > --- > > Fixed broken build due to signed comparison warning with GCC 5.3.0 > > > Diffs > - > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 632746211b1b43a23877de63a05777137be74c71 > > Diff: https://reviews.apache.org/r/42968/diff/ > > > Testing > --- > > make check > > > Thanks, > > Neil Conway > >
Re: Review Request 42968: Fixed broken build due to signed comparison warning with GCC 5.3.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42968/#review116977 --- Ship it! - Benjamin Bannier On Jan. 29, 2016, 7:32 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42968/ > --- > > (Updated Jan. 29, 2016, 7:32 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-4555 > https://issues.apache.org/jira/browse/MESOS-4555 > > > Repository: mesos > > > Description > --- > > Fixed broken build due to signed comparison warning with GCC 5.3.0 > > > Diffs > - > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 632746211b1b43a23877de63a05777137be74c71 > > Diff: https://reviews.apache.org/r/42968/diff/ > > > Testing > --- > > make check > > > Thanks, > > Neil Conway > >
Re: Review Request 42968: Fixed broken build due to signed comparison warning with GCC 5.3.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42968/#review116981 --- Ship it! Thanks Neil. Repeated field should compare with `int`. - Gilbert Song On Jan. 29, 2016, 10:32 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42968/ > --- > > (Updated Jan. 29, 2016, 10:32 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-4555 > https://issues.apache.org/jira/browse/MESOS-4555 > > > Repository: mesos > > > Description > --- > > Fixed broken build due to signed comparison warning with GCC 5.3.0 > > > Diffs > - > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 632746211b1b43a23877de63a05777137be74c71 > > Diff: https://reviews.apache.org/r/42968/diff/ > > > Testing > --- > > make check > > > Thanks, > > Neil Conway > >
