----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42996/#review117102 -----------------------------------------------------------
src/tests/resources_tests.cpp (lines 2036 - 2043) <https://reviews.apache.org/r/42996/#comment178189> Why need this case? I think that it does not related to shared resource and already covered by CreatePersistentVolume. You may want to test the shared cases here by creating a shared volume. - Guangya Liu On 一月 30, 2016, 1:35 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42996/ > ----------------------------------------------------------- > > (Updated 一月 30, 2016, 1:35 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-4324 > https://issues.apache.org/jira/browse/MESOS-4324 > > > Repository: mesos > > > Description > ------- > > Add unit tests for sharing of resources. > > > Diffs > ----- > > src/tests/master_validation_tests.cpp > 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 > src/tests/mesos.hpp c2bae4767ee7372c796bfad44ed1e86db7dd3488 > src/tests/persistent_volume_tests.cpp > cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0 > src/tests/resources_tests.cpp 4b25e82c13e4f46c73803f773db90f269c09c48a > > Diff: https://reviews.apache.org/r/42996/diff/ > > > Testing > ------- > > make check done. > > > Thanks, > > Anindya Sinha > >