Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

2016-02-24 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43035/#review120619
---


Ship it!




Ship It!

- Joris Van Remoortere


On Feb. 24, 2016, 11:41 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43035/
> ---
> 
> (Updated Feb. 24, 2016, 11:41 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check that even though we might fire a timer for a `GroupProcess` that has 
> been
> destroyed, this does not result in dispatching an event to a reclaimed 
> process.
> 
> 
> Diffs
> -
> 
>   src/tests/group_tests.cpp af530f32fac47801a2cd0d941f3aa9196d448bd2 
> 
> Diff: https://reviews.apache.org/r/43035/diff/
> 
> 
> Testing
> ---
> 
> `make check; ./src/mesos-tests --gtest_filter="GroupTest.TimerCleanup" 
> --gtest_repeat=4000 --gtest_break_on_failure`
> 
> I also verified that if you remove the `delete` of the `GroupProcess`, the 
> test fails because the `expired` callback is invoked (the `Clock::settle()` 
> is necessary to ensure that this happens).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

2016-02-24 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43035/
---

(Updated Feb. 24, 2016, 11:41 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Rebase.


Repository: mesos


Description
---

Check that even though we might fire a timer for a `GroupProcess` that has been
destroyed, this does not result in dispatching an event to a reclaimed process.


Diffs (updated)
-

  src/tests/group_tests.cpp af530f32fac47801a2cd0d941f3aa9196d448bd2 

Diff: https://reviews.apache.org/r/43035/diff/


Testing
---

`make check; ./src/mesos-tests --gtest_filter="GroupTest.TimerCleanup" 
--gtest_repeat=4000 --gtest_break_on_failure`

I also verified that if you remove the `delete` of the `GroupProcess`, the test 
fails because the `expired` callback is invoked (the `Clock::settle()` is 
necessary to ensure that this happens).


Thanks,

Neil Conway



Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

2016-02-16 Thread Neil Conway


> On Feb. 16, 2016, 2:09 p.m., Joris Van Remoortere wrote:
> > src/tests/group_tests.cpp, line 492
> > 
> >
> > Do you mean `Ensure that no pending messages are delivered.`?
> > Or `if any`, then what?

i.e., we want to check that if there are any pending messages, those messages 
are delivered. I clarified the comment to this effect.


> On Feb. 16, 2016, 2:09 p.m., Joris Van Remoortere wrote:
> > src/tests/group_tests.cpp, lines 450-456
> > 
> >
> > Can you explain why you needed to move this?

Can't recall :) I reverted this change.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43035/#review119309
---


On Feb. 16, 2016, 5:59 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43035/
> ---
> 
> (Updated Feb. 16, 2016, 5:59 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check that even though we might fire a timer for a `GroupProcess` that has 
> been
> destroyed, this does not result in dispatching an event to a reclaimed 
> process.
> 
> 
> Diffs
> -
> 
>   src/tests/group_tests.cpp af530f32fac47801a2cd0d941f3aa9196d448bd2 
> 
> Diff: https://reviews.apache.org/r/43035/diff/
> 
> 
> Testing
> ---
> 
> `make check; ./src/mesos-tests --gtest_filter="GroupTest.TimerCleanup" 
> --gtest_repeat=4000 --gtest_break_on_failure`
> 
> I also verified that if you remove the `delete` of the `GroupProcess`, the 
> test fails because the `expired` callback is invoked (the `Clock::settle()` 
> is necessary to ensure that this happens).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

2016-02-16 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43035/
---

(Updated Feb. 16, 2016, 5:59 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Address code review comments.


Repository: mesos


Description
---

Check that even though we might fire a timer for a `GroupProcess` that has been
destroyed, this does not result in dispatching an event to a reclaimed process.


Diffs (updated)
-

  src/tests/group_tests.cpp af530f32fac47801a2cd0d941f3aa9196d448bd2 

Diff: https://reviews.apache.org/r/43035/diff/


Testing
---

`make check; ./src/mesos-tests --gtest_filter="GroupTest.TimerCleanup" 
--gtest_repeat=4000 --gtest_break_on_failure`

I also verified that if you remove the `delete` of the `GroupProcess`, the test 
fails because the `expired` callback is invoked (the `Clock::settle()` is 
necessary to ensure that this happens).


Thanks,

Neil Conway



Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

2016-02-16 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43035/#review119309
---




src/tests/group_tests.cpp (lines 450 - 454)


Can you explain why you needed to move this?



src/tests/group_tests.cpp (line 483)


backticks for GroupProcess?



src/tests/group_tests.cpp (line 490)


Do you mean `Ensure that no pending messages are delivered.`?
Or `if any`, then what?


- Joris Van Remoortere


On Feb. 1, 2016, 9:40 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43035/
> ---
> 
> (Updated Feb. 1, 2016, 9:40 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check that even though we might fire a timer for a `GroupProcess` that has 
> been
> destroyed, this does not result in dispatching an event to a reclaimed 
> process.
> 
> 
> Diffs
> -
> 
>   src/tests/group_tests.cpp 6344fade519f47cd4ac3a2dc36c3237d9adf4cf8 
> 
> Diff: https://reviews.apache.org/r/43035/diff/
> 
> 
> Testing
> ---
> 
> `make check; ./src/mesos-tests --gtest_filter="GroupTest.TimerCleanup" 
> --gtest_repeat=4000 --gtest_break_on_failure`
> 
> I also verified that if you remove the `delete` of the `GroupProcess`, the 
> test fails because the `expired` callback is invoked (the `Clock::settle()` 
> is necessary to ensure that this happens).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

2016-02-01 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43035/#review117304
---



Patch looks great!

Reviews applied: [43033, 43065, 43034, 43035]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 1, 2016, 9:40 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43035/
> ---
> 
> (Updated Feb. 1, 2016, 9:40 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check that even though we might fire a timer for a `GroupProcess` that has 
> been
> destroyed, this does not result in dispatching an event to a reclaimed 
> process.
> 
> 
> Diffs
> -
> 
>   src/tests/group_tests.cpp 6344fade519f47cd4ac3a2dc36c3237d9adf4cf8 
> 
> Diff: https://reviews.apache.org/r/43035/diff/
> 
> 
> Testing
> ---
> 
> `make check; ./src/mesos-tests --gtest_filter="GroupTest.TimerCleanup" 
> --gtest_repeat=4000 --gtest_break_on_failure`
> 
> I also verified that if you remove the `delete` of the `GroupProcess`, the 
> test fails because the `expired` callback is invoked (the `Clock::settle()` 
> is necessary to ensure that this happens).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

2016-02-01 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43035/
---

(Updated Feb. 1, 2016, 9:40 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Tweak expectation to be stronger.


Repository: mesos


Description
---

Check that even though we might fire a timer for a `GroupProcess` that has been
destroyed, this does not result in dispatching an event to a reclaimed process.


Diffs (updated)
-

  src/tests/group_tests.cpp 6344fade519f47cd4ac3a2dc36c3237d9adf4cf8 

Diff: https://reviews.apache.org/r/43035/diff/


Testing
---

`make check; ./src/mesos-tests --gtest_filter="GroupTest.TimerCleanup" 
--gtest_repeat=4000 --gtest_break_on_failure`

I also verified that if you remove the `delete` of the `GroupProcess`, the test 
fails because the `expired` callback is invoked (the `Clock::settle()` is 
necessary to ensure that this happens).


Thanks,

Neil Conway



Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

2016-01-31 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43035/#review117153
---



Bad patch!

Reviews applied: [43033, 43034]

Failed command: ./support/apply-review.sh -n -r 43034

Error:
2016-01-31 20:35:12 URL:https://reviews.apache.org/r/43034/diff/raw/ 
[1097/1097] -> "43034.patch" [1]
Total errors found: 0
Checking 1 files
Error: Commit message summary (the first line) must start with a capital letter.

Full log: https://builds.apache.org/job/mesos-reviewbot/11154/console

- Mesos ReviewBot


On Jan. 31, 2016, 8:04 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43035/
> ---
> 
> (Updated Jan. 31, 2016, 8:04 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check that even though we might fire a timer for a `GroupProcess` that has 
> been
> destroyed, this does not result in dispatching an event to a reclaimed 
> process.
> 
> 
> Diffs
> -
> 
>   src/tests/group_tests.cpp 6344fade519f47cd4ac3a2dc36c3237d9adf4cf8 
> 
> Diff: https://reviews.apache.org/r/43035/diff/
> 
> 
> Testing
> ---
> 
> `make check; ./src/mesos-tests --gtest_filter="GroupTest.TimerCleanup" 
> --gtest_repeat=4000 --gtest_break_on_failure`
> 
> I also verified that if you remove the `delete` of the `GroupProcess`, the 
> test fails because the `expired` callback is invoked (the `Clock::settle()` 
> is necessary to ensure that this happens).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

2016-01-31 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43035/
---

(Updated Jan. 31, 2016, 8:04 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Avoid interaction between other tests.


Repository: mesos


Description
---

Check that even though we might fire a timer for a `GroupProcess` that has been
destroyed, this does not result in dispatching an event to a reclaimed process.


Diffs (updated)
-

  src/tests/group_tests.cpp 6344fade519f47cd4ac3a2dc36c3237d9adf4cf8 

Diff: https://reviews.apache.org/r/43035/diff/


Testing
---

`make check; ./src/mesos-tests --gtest_filter="GroupTest.TimerCleanup" 
--gtest_repeat=4000 --gtest_break_on_failure`

I also verified that if you remove the `delete` of the `GroupProcess`, the test 
fails because the `expired` callback is invoked (the `Clock::settle()` is 
necessary to ensure that this happens).


Thanks,

Neil Conway



Re: Review Request 43035: Added a test for the interaction between timers and destroyed Groups.

2016-01-31 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43035/
---

(Updated Jan. 31, 2016, 7:46 p.m.)


Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

Check that even though we might fire a timer for a `GroupProcess` that has been
destroyed, this does not result in dispatching an event to a reclaimed process.


Diffs
-

  src/tests/group_tests.cpp 6344fade519f47cd4ac3a2dc36c3237d9adf4cf8 

Diff: https://reviews.apache.org/r/43035/diff/


Testing (updated)
---

`make check; ./src/mesos-tests --gtest_filter="GroupTest.TimerCleanup" 
--gtest_repeat=4000 --gtest_break_on_failure`

I also verified that if you remove the `delete` of the `GroupProcess`, the test 
fails because the `expired` callback is invoked (the `Clock::settle()` is 
necessary to ensure that this happens).


Thanks,

Neil Conway