Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/#review117792 --- Bad patch! Reviews applied: [43136] Failed command:

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread haosdent huang
> On Feb. 4, 2016, 7:41 a.m., haosdent huang wrote: > > Ship It! > > haosdent huang wrote: > You combine `src/...` and `3rdparty/...` in a same patch, usually we > split them into different patches. And we have `support/hooks/pre-commit` to > check this when you execute `git commit`. Do

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread haosdent huang
> On Feb. 4, 2016, 7:41 a.m., haosdent huang wrote: > > Ship It! > > haosdent huang wrote: > You combine `src/...` and `3rdparty/...` in a same patch, usually we > split them into different patches. And we have `support/hooks/pre-commit` to > check this when you execute `git commit`. Do

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread haosdent huang
> On Feb. 4, 2016, 7:41 a.m., haosdent huang wrote: > > Ship It! > > haosdent huang wrote: > You combine `src/...` and `3rdparty/...` in a same patch, usually we > split them into different patches. And we have `support/hooks/pre-commit` to > check this when you execute `git commit`. Do

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread Andy Pang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/ --- (Updated 二月 4, 2016, 8:56 a.m.) Review request for mesos, BenjaminVW

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread haosdent huang
> On Feb. 4, 2016, 7:41 a.m., haosdent huang wrote: > > Ship It! > > haosdent huang wrote: > You combine `src/...` and `3rdparty/...` in a same patch, usually we > split them into different patches. And we have `support/hooks/pre-commit` to > check this when you execute `git commit`. Do

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread Andy Pang
> On 二月 4, 2016, 7:41 a.m., haosdent huang wrote: > > Ship It! > > haosdent huang wrote: > You combine `src/...` and `3rdparty/...` in a same patch, usually we > split them into different patches. And we have `support/hooks/pre-commit` to > check this when you execute `git commit`. Do you

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/#review117605 --- Patch looks great! Reviews applied: [43136] Passed command:

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/#review117595 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/#review117771 --- Ship it! Ship It! - haosdent huang On Feb. 4, 2016, 7:40

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-03 Thread Andy Pang
> On 二月 3, 2016, 8:43 a.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 71 > > > > > > Do we also need fix similar ::clone syscall in routing_tests.cpp? > > ``` >

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-03 Thread Andy Pang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/ --- (Updated 二月 4, 2016, 7:40 a.m.) Review request for mesos, BenjaminVW

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-03 Thread haosdent huang
> On Feb. 4, 2016, 7:41 a.m., haosdent huang wrote: > > Ship It! You combine `src/...` and `3rdparty/...` in a same patch, usually we split them into different patches. And we have `support/hooks/pre-commit` to check this when you execute `git commit`. Do you have already run `./bootstrap` in