Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43149/#review117805
---




3rdparty/libprocess/src/process.cpp (line 2204)


Check negative and zero value.



3rdparty/libprocess/src/process.cpp (line 2205)


Add test for this patch.


- Klaus Ma


On Feb. 4, 2016, 8:40 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43149/
> ---
> 
> (Updated Feb. 4, 2016, 8:40 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4592
> https://issues.apache.org/jira/browse/MESOS-4592
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check the LIBPROCESS_THREAD_COUNT environment variable to determine
> the number of threads in the libprocess thread pool.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 65a247a5bc7cf0bd6f23f6fc5c349ecce60f5ec0 
> 
> Diff: https://reviews.apache.org/r/43149/diff/
> 
> 
> Testing
> ---
> 
> make check on OS X. Running in production for many months.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

[Jiang Yan Xu]

> On Feb. 3, 2016, 5:11 p.m., Jiang Yan Xu wrote:
> > 3rdparty/libprocess/src/process.cpp, lines 2207-2208
> > 
> >
> > Since we do LOG(WARNING) instead of LOG(FATAL), maybe say the below so 
> > it's clear that we ignored the variable and moved on with the default value.
> > 
> > `"Ignoring invalid value " << value.get() << " for 
> > LIBPROCESS_THREAD_COUNT";`
> 
> Guangya Liu wrote:
> What about adding more info for trouble shooting? Such as `"Ignoring 
> invalid value " << value.get() << " for LIBPROCESS_THREAD_COUNT, using system 
> defined value " << cpus;`
> 
> haosdent huang wrote:
> +1

Hmm... either this or we just EXIT(EXIT_FAILURE). I am leaning towards the 
latter after thinking about it a bit more. It's also more consistent with 
practices in this file: e.g. when LIBPROCESS_PORT is invalid we don't use the 
default port (and elsewhere in the project).


> On Feb. 3, 2016, 5:11 p.m., Jiang Yan Xu wrote:
> > 3rdparty/libprocess/src/process.cpp, line 2203
> > 
> >
> > `Try count = numify(...)` since the thread count is an 
> > uint?

My bad for suggesting using numify. Seems like numify actually 
is going to underflow for a negative long and output a large number. So we 
ought to keep using long and do boundary checks explicitly. i.e. count.get() > 0


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43149/#review117725
---


On Feb. 3, 2016, 4:40 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43149/
> ---
> 
> (Updated Feb. 3, 2016, 4:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4592
> https://issues.apache.org/jira/browse/MESOS-4592
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check the LIBPROCESS_THREAD_COUNT environment variable to determine
> the number of threads in the libprocess thread pool.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 65a247a5bc7cf0bd6f23f6fc5c349ecce60f5ec0 
> 
> Diff: https://reviews.apache.org/r/43149/diff/
> 
> 
> Testing
> ---
> 
> make check on OS X. Running in production for many months.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43149/#review117776
---



It is duplicate with https://reviews.apache.org/r/43144/

- Guangya Liu


On Feb. 4, 2016, 12:40 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43149/
> ---
> 
> (Updated Feb. 4, 2016, 12:40 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4592
> https://issues.apache.org/jira/browse/MESOS-4592
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check the LIBPROCESS_THREAD_COUNT environment variable to determine
> the number of threads in the libprocess thread pool.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 65a247a5bc7cf0bd6f23f6fc5c349ecce60f5ec0 
> 
> Diff: https://reviews.apache.org/r/43149/diff/
> 
> 
> Testing
> ---
> 
> make check on OS X. Running in production for many months.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43149/#review117693
---



Bad patch!

Reviews applied: [43149]

Failed command: ./support/apply-review.sh -n -r 43149

Error:
2016-02-03 22:26:52 URL:https://reviews.apache.org/r/43149/diff/raw/ 
[1562/1562] -> "43149.patch" [1]
Total errors found: 0
Checking 1 files
ERROR: Commit spanning multiple projects.

Please use separate commits for mesos, libprocess and stout.

Paths grouped by project:
mesos:
  docs/configuration.md
libprocess:
  3rdparty/libprocess/src/process.cpp

Full log: https://builds.apache.org/job/mesos-reviewbot/11224/console

- Mesos ReviewBot


On Feb. 3, 2016, 9:38 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43149/
> ---
> 
> (Updated Feb. 3, 2016, 9:38 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4592
> https://issues.apache.org/jira/browse/MESOS-4592
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check the LIBPROCESS_THREAD_COUNT environment variable to determine
> the number of threads in the libprocess thread pool.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 65a247a5bc7cf0bd6f23f6fc5c349ecce60f5ec0 
>   docs/configuration.md 4b5a394685b597704fe0f6bc038496295e19f6e1 
> 
> Diff: https://reviews.apache.org/r/43149/diff/
> 
> 
> Testing
> ---
> 
> make check on OS X. Running in production for many months.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43149/
---

(Updated Feb. 4, 2016, 12:14 a.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4592
https://issues.apache.org/jira/browse/MESOS-4592


Repository: mesos


Description
---

Check the LIBPROCESS_THREAD_COUNT environment variable to determine
the number of threads in the libprocess thread pool.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp 65a247a5bc7cf0bd6f23f6fc5c349ecce60f5ec0 

Diff: https://reviews.apache.org/r/43149/diff/


Testing
---

make check on OS X. Running in production for many months.


Thanks,

James Peach

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

[Guangya Liu]

> On Feb. 4, 2016, 1:11 a.m., Jiang Yan Xu wrote:
> > 3rdparty/libprocess/src/process.cpp, lines 2207-2208
> > 
> >
> > Since we do LOG(WARNING) instead of LOG(FATAL), maybe say the below so 
> > it's clear that we ignored the variable and moved on with the default value.
> > 
> > `"Ignoring invalid value " << value.get() << " for 
> > LIBPROCESS_THREAD_COUNT";`

What about adding more info for trouble shooting? Such as `"Ignoring invalid 
value " << value.get() << " for LIBPROCESS_THREAD_COUNT, using system defined 
value " << cpus;`


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43149/#review117725
---


On Feb. 4, 2016, 12:40 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43149/
> ---
> 
> (Updated Feb. 4, 2016, 12:40 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4592
> https://issues.apache.org/jira/browse/MESOS-4592
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check the LIBPROCESS_THREAD_COUNT environment variable to determine
> the number of threads in the libprocess thread pool.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 65a247a5bc7cf0bd6f23f6fc5c349ecce60f5ec0 
> 
> Diff: https://reviews.apache.org/r/43149/diff/
> 
> 
> Testing
> ---
> 
> make check on OS X. Running in production for many months.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43149/#review117725
---




3rdparty/libprocess/src/process.cpp (line 2203)


`Try count = numify(...)` since the thread count is an uint?



3rdparty/libprocess/src/process.cpp (lines 2207 - 2208)


Since we do LOG(WARNING) instead of LOG(FATAL), maybe say the below so it's 
clear that we ignored the variable and moved on with the default value.

`"Ignoring invalid value " << value.get() << " for 
LIBPROCESS_THREAD_COUNT";`


- Jiang Yan Xu


On Feb. 3, 2016, 4:40 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43149/
> ---
> 
> (Updated Feb. 3, 2016, 4:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4592
> https://issues.apache.org/jira/browse/MESOS-4592
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check the LIBPROCESS_THREAD_COUNT environment variable to determine
> the number of threads in the libprocess thread pool.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 65a247a5bc7cf0bd6f23f6fc5c349ecce60f5ec0 
> 
> Diff: https://reviews.apache.org/r/43149/diff/
> 
> 
> Testing
> ---
> 
> make check on OS X. Running in production for many months.
> 
> 
> Thanks,
> 
> James Peach
> 
>