Re: Review Request 43182: Support libprocess build run in aarch64 cpu.

2016-07-09 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43182/#review141538
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Feb. 4, 2016, 9:33 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43182/
> ---
> 
> (Updated Feb. 4, 2016, 9:33 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-4577
> https://issues.apache.org/jira/browse/MESOS-4577
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support libprocess build run in aarch64 cpu.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 
> f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 
> 
> Diff: https://reviews.apache.org/r/43182/diff/
> 
> 
> Testing
> ---
> 
> test run ok in AArch64.
> 
> 
> Thanks,
> 
> Andy Pang
> 
>



Re: Review Request 43182: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43182/#review117789
---


Ship it!




Actually I not sure whether use a var to replace `2` or `1` would better or 
not. If it really could works on aarch64(I don't have a aarch64 machine), it 
looks good to me.

- haosdent huang


On Feb. 4, 2016, 9:33 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43182/
> ---
> 
> (Updated Feb. 4, 2016, 9:33 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-4577
> https://issues.apache.org/jira/browse/MESOS-4577
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support libprocess build run in aarch64 cpu.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 
> f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 
> 
> Diff: https://reviews.apache.org/r/43182/diff/
> 
> 
> Testing
> ---
> 
> test run ok in AArch64.
> 
> 
> Thanks,
> 
> Andy Pang
> 
>